Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amcharts bundles megabytes of unused dependencies #350

Closed
kleinfreund opened this issue Aug 15, 2022 · 1 comment
Closed

amcharts bundles megabytes of unused dependencies #350

kleinfreund opened this issue Aug 15, 2022 · 1 comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@kleinfreund
Copy link
Contributor

What happened?

The @amcharts/amcharts4 package we’re using for charts is distributed in a very problematic manner which adds several megabytes of data to the production bundle of Kuma GUI.

This is discussed at length in amcharts/amcharts4#82.

Just the following two entries total 2.5 MB in uncompressed size. Of the 1.76 MB, well over half of the size is taken up by amcharts.

  File                                    Size                                                  Gzipped
dist/js/pdfmake.js                      2113.96 KiB                                           925.98 KiB
dist/js/xlsx.js                         480.08 KiB                                            156.79 KiB

We should consider an alternative that is bundled and distributed correctly.

@kleinfreund kleinfreund added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Aug 15, 2022
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Aug 16, 2022
@kleinfreund kleinfreund self-assigned this Aug 24, 2022
@kleinfreund
Copy link
Contributor Author

In #361, I’ll mark those dependencies as external so they’re no longer bundled with the application.

@kleinfreund kleinfreund removed their assignment Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants