Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mocks: remove healthStatus and globalInsightServices #3126

Open
johncowen opened this issue Oct 29, 2024 · 0 comments
Open

mocks: remove healthStatus and globalInsightServices #3126

johncowen opened this issue Oct 29, 2024 · 0 comments
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
backlog

Comments

@johncowen
Copy link
Contributor

johncowen commented Oct 29, 2024 •
edited
Loading

What happened?

Both fake.kuma.healthStatus and fake.kuma.globalInsightServices are buggy, unreliable and hide the JSON structure (there might be more methods that use these 2, which should also be removed)

We should use fake.kuma.partitionInto for these sorts of things instead.

See #3125
@johncowen johncowen added triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Oct 29, 2024
@johncowen johncowen added this to the backlog milestone Nov 4, 2024
@bartsmykla bartsmykla added triage/accepted The issue was reviewed and is complete enough to start working on it kind/cleanup Cleanup/refactor an existing component/code and removed triage/pending This issue will be looked at on the next triage meeting kind/bug A bug labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
2 participants
@johncowen @bartsmykla