Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure dependabot bumps the MSW mockServiceWorker file when bumping MSW upgrades #3096

Open
johncowen opened this issue Oct 25, 2024 · 1 comment
Open

ensure dependabot bumps the MSW mockServiceWorker file when bumping MSW upgrades #3096

johncowen opened this issue Oct 25, 2024 · 1 comment
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
backlog

Comments

@johncowen
Copy link
Contributor

Description

More details here #2918

The above PR was work towards this issue (mainly testing out "only do something on dependabot PRs" functionality) but next steps would be to make the GHA also bump this file and commit to the existing PR.
@johncowen johncowen added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Oct 25, 2024
@johncowen johncowen mentioned this issue Oct 25, 2024
Merged
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/cleanup Cleanup/refactor an existing component/code and removed triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Oct 28, 2024
@johncowen
Copy link
Contributor Author

We recently changed PRs to use the PR description for the merge commit message, which is great for our own PRs, but terrible for dependabot PRs (they are full of HTML)

We've taken to copying the last commit message to use for the merge commit for any dependabot PRs.

It would also be nice to replace the default dependabot description with the last commit message, and then put dependabots description as a comment on the PR so we have/keep links to all the information contained in there.

If either of these things gets done, feel free to split this issue into two in order to close one but not the other - or if its easier to do both tasks in one thats fine also.

@johncowen johncowen added this to the backlog milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
2 participants
@johncowen @jakubdyszkiewicz