Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kuma-gui to use workspaces #3009

Open
3 tasks
johncowen opened this issue Sep 25, 2024 · 0 comments
Open
3 tasks

Move kuma-gui to use workspaces #3009

johncowen opened this issue Sep 25, 2024 · 0 comments
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@johncowen
Copy link
Contributor

Description

Since we started refactoring our application, the majority of our application "modules" in /src/app have been imagined as separate npm packages, just it has always been too much churn to move them/"promote" them to fully-fledged npm packages.

We also have certain usecases where we would like to publish or otherwise consume certain packages on their own, and/or move certain files into consumable packages (such as all our tooling configuration).

In order to start making our final steps towards these outcome we should move our repository to use workspaces:

  • move the entire application into /apps/kuma-gui and have it be buildable/testable/deployable as usual.
  • make a new workspace/package in /packages/config to house consumable configuration and have /apps/kuma-gui depend on this for all tooling configuration.
  • on a case-by-case basis move each /src/app/* module into its own workspace/package, and have /apps/kuma-gui depend on it. These should not live in /apps but instead in /packages or possibly /modules (this decision is tbd)

The first point above can probably be a single PR, but the remaining two are probably several.

@johncowen johncowen added triage/pending This issue will be looked at on the next triage meeting kind/cleanup Cleanup/refactor an existing component/code labels Sep 25, 2024
@lobkovilya lobkovilya added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Sep 30, 2024
@johncowen johncowen added this to the backlog milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants