Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs:fix-doc-typos-and-links Fix slack links and typos #1404

Merged
merged 2 commits into from
Feb 21, 2020
Merged

docs:fix-doc-typos-and-links Fix slack links and typos #1404

merged 2 commits into from
Feb 21, 2020

Conversation

chris-mcdermut-vacasa
Copy link
Contributor

What
Fixing broken slack links and some minor typos in documentation

Discussion
https://ts-jest.slack.com/archives/CC6B0LYJD/p1582074011015000

Test Steps

  1. Review documentation changes
  2. Test slack bit.ly link: https://bit.ly/3bRHFPQ

@coveralls
Copy link

coveralls commented Feb 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 4054

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.72%
Totals Coverage Status
Change from base Build 4053: 0.0%
Covered Lines: 1087
Relevant Lines: 1132
💛 - Coveralls

kulshekhar
kulshekhar approved these changes Feb 21, 2020
View reviewed changes
Copy link
Owner

@kulshekhar kulshekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @chris-mcdermut-vacasa

@ahnpnl ahnpnl merged commit 3e2e008 into kulshekhar:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnpnl ahnpnl ahnpnl approved these changes

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chris-mcdermut-vacasa @coveralls @kulshekhar @ahnpnl