Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct typescript package in yarn workspaces #1377

Merged
merged 3 commits into from
Feb 8, 2020
Merged

fix: use correct typescript package in yarn workspaces #1377

merged 3 commits into from
Feb 8, 2020

Conversation

andreialecu
Copy link
Contributor

@andreialecu andreialecu commented Feb 7, 2020 •
edited
Loading

Fixes #1333

@andreialecu andreialecu mentioned this pull request Feb 7, 2020
Closed
@andreialecu andreialecu changed the title fix: use resolve package to find typescript fix: use correct typescript package in yarn workspaces Feb 7, 2020
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3970

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.479%
Totals Coverage Status
Change from base Build 3967: 0.01%
Covered Lines: 1069
Relevant Lines: 1125
💛 - Coveralls

@andreialecu
Copy link
Contributor Author

andreialecu commented Feb 7, 2020 •
edited
Loading

There might be a better fix possible, but this seems to fix the repro in #1333 and I don't think there should be any side effects.

ahnpnl
ahnpnl approved these changes Feb 8, 2020
View reviewed changes
Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping us. LGTM 👍
I tested a bit and so far I don't see anything wrong.

@ahnpnl ahnpnl merged commit a63808c into kulshekhar:master Feb 8, 2020
@ahnpnl ahnpnl mentioned this pull request Feb 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahnpnl ahnpnl ahnpnl approved these changes

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ts-jest using wrong typescript version with yarn workspaces/monorepo (repro)
4 participants
@andreialecu @coveralls @kulshekhar @ahnpnl