feat: support Jest 25 v2 #1355
Merged
feat: support Jest 25 v2 #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st25 � Conflicts: � e2e/__templates__/default/package-lock.json � e2e/__templates__/default/package.json � e2e/__templates__/with-babel-7/package-lock.json � e2e/__templates__/with-babel-7/package.json � e2e/__templates__/with-typescript-2-7/package-lock.json � e2e/__templates__/with-typescript-2-7/package.json � e2e/__templates__/with-unsupported-version/package-lock.json � e2e/__templates__/with-unsupported-version/package.json � package-lock.json
Merged
|
@kulshekhar Any ideas why deep-path.test.ts would be failing? |
|
hi @kibertoad , would you please also including update e2e template into this PR ? You can use command updated Sorry my bad I saw e2e templates were included already. |
|
@kibertoad I'm not sure. I'll take a look once the CI run is done to see if there's anything I can identify offhand |
|
@kibertoad I think, in the failing tests, the snapshots just have to be regenerated |
Pull Request Test Coverage Report for Build 3889
💛 - Coveralls |
|
@kulshekhar It's green now! |
kulshekhar
reviewed
Jan 22, 2020
package.json
Outdated
| @@ -69,7 +70,7 @@ | |||
| "yargs-parser": "10.x" | |||
| }, | |||
| "peerDependencies": { | |||
| "jest": ">=24 <25" | |||
| "jest": ">=24 <26" | |||
kulshekhar
reviewed
Jan 22, 2020
src/util/version-checkers.ts
Outdated
| TypeScript = '>=2.7 <4', | ||
| BabelJest = '>=24 <25', | ||
| BabelJest = '>=24 <26', |
kulshekhar
reviewed
Jan 22, 2020
src/util/version-checkers.ts
Outdated
| @@ -10,9 +10,9 @@ const logger = rootLogger.child({ namespace: 'versions' }) | |||
| * @internal | |||
| */ | |||
| export enum ExpectedVersions { | |||
| Jest = '>=24 <25', | |||
| Jest = '>=24 <26', | |||
|
@kibertoad thanks! Just added a request for a few minor changes |
|
@kulshekhar Addressed! |
|
@kulshekhar Aaaaand it's green again. |
kulshekhar
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
@kibertoad @sodatea thanks for your work! I'll have a release out shortly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1232
fixes #1354