From 42f352116637d90c2e814f610c1ca27498e2eda4 Mon Sep 17 00:00:00 2001 From: Muhammad Haziq Date: Mon, 20 Jun 2022 15:56:54 +0500 Subject: [PATCH] let webinars update API accepts language interpretation in settings --- lib/zoom/actions/webinar.rb | 36 ++++++++++++++++++------------------ lib/zoom/params.rb | 10 +++++++++- spec/lib/zoom/params_spec.rb | 18 ++++++++++++++++++ 3 files changed, 45 insertions(+), 19 deletions(-) diff --git a/lib/zoom/actions/webinar.rb b/lib/zoom/actions/webinar.rb index 4f671d38..90b896fc 100644 --- a/lib/zoom/actions/webinar.rb +++ b/lib/zoom/actions/webinar.rb @@ -8,24 +8,24 @@ module Webinar RECURRENCE_KEYS = %i[type repeat_interval weekly_days monthly_day monthly_week monthly_week_day end_times end_date_time].freeze SETTINGS_KEYS = [ - %i[ - host_video panelists_video practice_session hd_video approval_type - registration_type audio auto_recording enforce_login - enforce_login_domains alternative_hosts close_registration - show_share_button allow_multiple_devices on_demand - request_permission_to_unmute_participants global_dial_in_countries - contact_name contact_email registrants_restrict_number - post_webinar_survey survey_url registrants_email_notification - meeting_authentication authentication_option - authentication_domains registrants_confirmation_email - ].freeze, - { - question_and_answer: %i[ - allow_anonymous_questions, answer_questions, attendees_can_comment, - attendees_can_upvote, enable - ] - } - ] + :host_video, :panelists_video, :practice_session, :hd_video, :approval_type, + :registration_type, :audio, :auto_recording, :enforce_login, + :enforce_login_domains, :alternative_hosts, :close_registration, + :show_share_button, :allow_multiple_devices, :on_demand, + :request_permission_to_unmute_participants, :global_dial_in_countries, + :contact_name, :contact_email, :registrants_restrict_number, + :post_webinar_survey, :survey_url, :registrants_email_notification, + :meeting_authentication, :authentication_option, + :authentication_domains, :registrants_confirmation_email, + { language_interpretation: [ + :enable, + interpreters: %i[email languages] + ], + question_and_answer: %i[ + allow_anonymous_questions answer_questions attendees_can_comment + attendees_can_upvote enable + ] } + ].freeze get 'webinar_list', '/users/:host_id/webinars', permit: %i[page_size page_number] diff --git a/lib/zoom/params.rb b/lib/zoom/params.rb index ad811880..71aa530e 100644 --- a/lib/zoom/params.rb +++ b/lib/zoom/params.rb @@ -32,7 +32,7 @@ def permit(*filters) array << hash_filter(filter) end end - non_permitted_params = @parameters.keys - permitted_keys.flatten + non_permitted_params = parameters_keys - permitted_keys.flatten raise Zoom::ParameterNotPermitted, non_permitted_params.to_s unless non_permitted_params.empty? end @@ -106,5 +106,13 @@ def permit_value(key, values) raise Zoom::ParameterValueNotPermitted, "#{key}: #{value}" end end + + def parameters_keys + if @parameters.kind_of?(Array) + @parameters.map(&:keys).flatten.uniq + else + @parameters.keys + end + end end end diff --git a/spec/lib/zoom/params_spec.rb b/spec/lib/zoom/params_spec.rb index 532a1a2c..3005e6b7 100644 --- a/spec/lib/zoom/params_spec.rb +++ b/spec/lib/zoom/params_spec.rb @@ -98,4 +98,22 @@ expect { params.permit_value(:baz, values) }.to raise_error(Zoom::ParameterValueNotPermitted, "#{:baz.to_s}: #{:bang.to_s}") end end + + describe '#parameters_keys' do + context 'when param is array ' do + let(:params) { Zoom::Params.new([{foo: :bar, baz: :bang}, {foo: :bar1, baz: :bang1}]) } + + it 'get each object keys and return unique of them' do + expect(params.parameters_keys).to eq([:foo, :baz]) + end + end + + context 'when param is Hash ' do + let(:params) { Zoom::Params.new({foo: :bar, baz: :bang}) } + + it 'return hash keys' do + expect(params.parameters_keys).to eq([:foo, :baz]) + end + end + end end