performance issues with overcommit webhook

[googs1025]

Will there be performance issues with the overcommit implementation of katalyst-core's internal webhook? If there are hundreds of nodes in the cluster.

[googs1025]

/kind support

[WangZzzhe]

The QPS of the webhook will increase with the increase of the number of nodes in the cluster. To address this issue, we have simplified the design of the webhook. In the current version, the overcommit webhook will not do any matching or calculation, and directly use the calculation results of the katalyst overcommit controller to update the node status. If there are a large number of nodes your cluster , it is recommended to gradually apply the overcommit for nodes and monitor the resource metrics of the webhook. @googs1025

[googs1025]

@WangZzzhe
Thanks for your answer. I still see the calculation operation in the source code
refer to:
https://github.com/kubewharf/katalyst-core/blob/main/pkg/webhook/mutating/node/allocatable_mutator.go#L101

[googs1025]

But I don't think this calculation will affect performance. What I care about is whether we took performance into consideration when designing.

[HaijunMa]

But I don't think this calculation will affect performance. What I care about is whether we took performance into consideration when designing.

What are the main aspects of the performance impact you are talking about?

[googs1025]

But I don't think this calculation will affect performance. What I care about is whether we took performance into consideration when designing.

What are the main aspects of the performance impact you are talking about?

We may have hundreds of nodes in our cluster, and I am not sure if there will be any performance issues

[googs1025]

Because hundreds of nodes need to report heartbeat information through this webhook