New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor some methods of node webhook #577

Open

googs1025 opened this issue May 8, 2024 · 1 comment · May be fixed by #578

Assignees

Labels

Milestone

Contributor

googs1025 commented May 8, 2024

What happened?

When I was using katalyst recently, I found that there were some duplicate codes in the webhook code. I wanted to do a small refactoring and simplify some codes.
like this
https://github.com/kubewharf/katalyst-core/blob/main/pkg/webhook/mutating/node/allocatable_mutator.go#L66
https://github.com/kubewharf/katalyst-core/blob/main/pkg/webhook/mutating/node/allocatable_mutator.go#L121

Contributor Author

googs1025 commented May 8, 2024

/assign

caohe assigned googs1025

caohe added the refactor label

caohe added this to the v0.6 milestone

googs1025 linked a pull request

that will close this issue

refector: refector node webhook #578

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment