Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

CreateVmDialog: V2V VMware report deployment status/errors #486

Conversation

atiratree
Copy link
Contributor

depends on #485 being merged first

@coveralls
Copy link

coveralls commented May 31, 2019

Pull Request Test Coverage Report for Build 2009

  • 104 of 120 (86.67%) changed or added relevant lines in 18 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 82.772%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/k8s/requests/v2v/startV2VvmwareController.js 0 1 0.0%
src/k8s/util/k8sMethodsUtils.js 0 3 0.0%
src/components/Wizard/CreateVmWizard/providers/VMwareImportProvider/VMWareObjectStatus.js 5 11 45.45%
src/components/Wizard/CreateVmWizard/stateUpdate/providers/vmWareStateUpdate.js 9 15 60.0%
Files with Coverage Reduction New Missed Lines %
src/k8s/util/k8sMethodsUtils.js 1 11.36%
src/k8s/requests/v2v/startV2VvmwareController.js 1 13.33%
Totals Coverage Status
Change from base Build 2005: 0.2%
Covered Lines: 3926
Relevant Lines: 4534

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1728

  • 108 of 124 (87.1%) changed or added relevant lines in 18 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 82.772%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/k8s/requests/v2v/startV2VvmwareController.js 0 1 0.0%
src/k8s/util/k8sMethodsUtils.js 0 3 0.0%
src/components/Wizard/CreateVmWizard/providers/VMwareImportProvider/VMWareObjectStatus.js 5 11 45.45%
src/components/Wizard/CreateVmWizard/stateUpdate/providers/vmWareStateUpdate.js 13 19 68.42%
Files with Coverage Reduction New Missed Lines %
src/k8s/util/k8sMethodsUtils.js 1 11.36%
src/k8s/requests/v2v/startV2VvmwareController.js 1 13.33%
Totals Coverage Status
Change from base Build 1684: 0.2%
Covered Lines: 3926
Relevant Lines: 4534

💛 - Coveralls

Copy link
Contributor

@mareklibra mareklibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if rebased

@atiratree atiratree force-pushed the web-ui-2.0-v2v.report-failing-deployment branch from 644624b to 1913053 Compare May 31, 2019 13:03
@atiratree
Copy link
Contributor Author

rebased

@mareklibra mareklibra merged commit b8af04d into kubevirt:web-ui-v2.0.0 Jun 3, 2019
@mareklibra
Copy link
Contributor

Example of failing deployment:

v2vDeploymentError

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants