This repository has been archived by the owner on Apr 28, 2020. It is now read-only.
Backport: Fix rendered disk size <1Gi #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If disk size is < 1 Gi in the Storage Tab of CreateVmWizard, the value is reformatted and appended by a lower matching unit. Corresponding PVC is created with a value conforming the format required by Kubernetes.
To be consistent with the newly introduced `rederValueConfig()`
Let's keep using "Gi" as the base unit. In a later version, we will implement proper unit-selector.
Pull Request Test Coverage Report for Build 1602
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1863
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #452