Skip to content
This repository has been archived by the owner on Apr 28, 2020. It is now read-only.

css updates for details/charts (#383) #409

Merged
merged 1 commit into from
Apr 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sass/components/ClusterOverview/health.scss
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,10 @@

.kubevirt-dashboard__card {
min-height: 120px;
height: 100%;
}

.pf-l-grid-item {
height: 100%;
}
}
9 changes: 6 additions & 3 deletions sass/components/Dashboard/capacity.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,8 @@
display: flex;
flex-direction: column;
text-align: center;
flex-grow: 0;
width: 11em;
height: 15em;
justify-content: space-between;
flex: 0 1 120px;
}

.kubevirt-capacity__item-title {
Expand All @@ -34,4 +33,8 @@
overflow: visible;
}
}

.kubevirt-capacity__card {
height: 100%;
}
/* stylelint-enable */
17 changes: 10 additions & 7 deletions sass/components/Dashboard/detail.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,22 @@
margin-bottom: 1rem;
}

.kubevirt-detail__list {
display: flex;
flex-wrap: wrap;
}

.kubevirt-detail__item-title {
float: left;
clear: left;
// width: 150px;
margin-bottom: 5px;
font-size: 14px;
font-size: 0.875rem;
text-transform: capitalize;
flex-basis: 100%;
}

.kubevirt-detail__item-value {
margin: 0 0 5px 160px;
font-size: 14px;
font-size: 0.875rem;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
flex-basis: 100%;
margin-bottom: 8px;
}
7 changes: 6 additions & 1 deletion sass/components/Dashboard/events.scss
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@
.co-sysevent__subheader > *:not(:first-child) {
margin-left: 6px;
}

.co-sysevent-stream__status-box-empty {
margin-right: 15px;
}
}

.kubevirt-events__timestamp i {
Expand All @@ -60,9 +64,10 @@
/* stylelint-enable */

.kubevirt-events__card-body {
margin: 0;
margin: 0 -15px 0 0;
padding: 0;
overflow-y: auto;
overflow-x: hidden;
}

.kubevirt-events__card-header {
Expand Down
2 changes: 1 addition & 1 deletion sass/components/StorageOverview/data-resiliency.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
}

.kubevirt-data-resiliency__icon-error {
color: red;
color: #c9190b;
}

.kubevirt-data-resiliency__status-title-ok {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ exports[`<Details /> renders correctly 1`] = `
<div
class="card-pf-body"
>
<dl>
<dl
class="kubevirt-detail__list"
>
<dt
class="kubevirt-detail__item-title"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ exports[`<ClusterOverview /> renders correctly with Provider 1`] = `
<div
class="card-pf-body"
>
<dl>
<dl
class="kubevirt-detail__list"
>
<dt
class="kubevirt-detail__item-title"
>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Dashboard/Details/DetailsBody.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';

export const DetailsBody = ({ children }) => <dl>{children}</dl>;
export const DetailsBody = ({ children }) => <dl className="kubevirt-detail__list">{children}</dl>;

DetailsBody.propTypes = {
children: PropTypes.oneOfType([PropTypes.node, PropTypes.func]).isRequired,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`<DetailsBody /> renders correctly 1`] = `
<dl>
<dl
class="kubevirt-detail__list"
>
<dt
class="kubevirt-detail__item-title"
>
Expand Down
2 changes: 1 addition & 1 deletion src/components/StorageOverview/Capacity/Capacity.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { getCapacityStats } from '../../../selectors';
import { CapacityBody } from '../../Dashboard/Capacity/CapacityBody';

export const Capacity = ({ capacityTotal, capacityUsed, LoadingComponent }) => (
<DashboardCard>
<DashboardCard className="kubevirt-capacity__card">
<DashboardCardHeader>
<DashboardCardTitle>Capacity</DashboardCardTitle>
</DashboardCardHeader>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`<Capacity /> renders correctly 1`] = `
<div
class="card-pf kubevirt-dashboard__card"
class="card-pf kubevirt-dashboard__card kubevirt-capacity__card"
>
<div
class="card-pf-heading kubevirt-dashboard__card-heading"
Expand Down Expand Up @@ -101,7 +101,7 @@ exports[`<Capacity /> renders correctly 1`] = `

exports[`<Capacity /> renders correctly in Loading state 1`] = `
<div
class="card-pf kubevirt-dashboard__card"
class="card-pf kubevirt-dashboard__card kubevirt-capacity__card"
>
<div
class="card-pf-heading kubevirt-dashboard__card-heading"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ exports[`<Details /> renders correctly 1`] = `
<div
class="card-pf-body"
>
<dl>
<dl
class="kubevirt-detail__list"
>
<dt
class="kubevirt-detail__item-title"
>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ exports[`<StorageOverview /> renders correctly with Provider 1`] = `
<div
class="card-pf-body"
>
<dl>
<dl
class="kubevirt-detail__list"
>
<dt
class="kubevirt-detail__item-title"
>
Expand Down