From 678739d130ad00a8531f323a6408e2aad6fc8e2f Mon Sep 17 00:00:00 2001 From: Daniel Hiller Date: Fri, 19 Jul 2024 08:29:00 +0200 Subject: [PATCH] owners, user-guide: set up owners from sigs (#819) Since we have the sigs formed for the several topics, let's establish ownership of the sections by each respective sig. Also we remove some users from the reviewers section who haven't shown review activity for the last six months - this way we avoid assigning them to the reviews and getting reviews stalled. See https://kubevirt.devstats.cncf.io/d/46/pr-reviews-by-contributor?orgId=1&var-period=d7&var-repo_name=kubevirt%2Fuser-guide&var-reviewers=%22davidvossel%22&var-reviewers=%22rmohr%22&var-reviewers=%22stu-gott%22 Signed-off-by: Daniel Hiller --- OWNERS | 36 ++------- OWNERS_ALIASES | 139 +++++++++++++++++++++++++++++++++++ docs/cluster_admin/OWNERS | 8 ++ docs/compute/OWNERS | 8 ++ docs/debug_virt_stack/OWNERS | 8 ++ docs/network/OWNERS | 8 ++ docs/storage/OWNERS | 8 ++ 7 files changed, 186 insertions(+), 29 deletions(-) create mode 100644 OWNERS_ALIASES create mode 100644 docs/cluster_admin/OWNERS create mode 100644 docs/compute/OWNERS create mode 100644 docs/debug_virt_stack/OWNERS create mode 100644 docs/network/OWNERS create mode 100644 docs/storage/OWNERS diff --git a/OWNERS b/OWNERS index 8e7a04b77..25e53a3d9 100644 --- a/OWNERS +++ b/OWNERS @@ -1,37 +1,15 @@ filters: ".*": reviewers: - - davidvossel - - vladikr - - rmohr - - stu-gott - - fabiand - - AlonaKaplan - - dhiller - - jean-edouard - - mhenriks - - phoracek - - cwilkers - - jobbler - - aburdenthehand + - reviewers approvers: - - davidvossel - - vladikr - - rmohr - - stu-gott - - fabiand - - AlonaKaplan - - dhiller - - jean-edouard - - mhenriks - - phoracek - - cwilkers + - approvers emeritus_approvers: - - ashleyschuett - - codificat - - hroyrh - - danielBelenky - - mazzystr + - ashleyschuett + - codificat + - hroyrh + - danielBelenky + - mazzystr "^docs/.*": labels: diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES new file mode 100644 index 000000000..ed22f72c3 --- /dev/null +++ b/OWNERS_ALIASES @@ -0,0 +1,139 @@ +aliases: + reviewers: + - vladikr + - fabiand + - AlonaKaplan + - dhiller + - jean-edouard + - mhenriks + - phoracek + - cwilkers + - jobbler + - aburdenthehand + approvers: + - davidvossel + - vladikr + - rmohr + - stu-gott + - fabiand + - AlonaKaplan + - dhiller + - jean-edouard + - mhenriks + - phoracek + - cwilkers + + # + # SIG Test + # + sig-test-reviewers: + - kbidarkar + sig-test-approvers: + - kbidarkar + - phoracek + - enp0s3 + - xpivarc + - acardace + - dhiller + - AlonaKaplan + + # + # SIG Network + # Owns anything related to networking. + # + sig-network-reviewers: + - AlonaKaplan + - EdDev + - RamLavi + - ormergi + sig-network-approvers: + - AlonaKaplan + - EdDev + + # + # SIG Scale + # Owns to keep kubevirt's scalability comparable to Kubernetes'. + # + sig-scale-approvers: + - rthallisey + sig-scale-reviewers: + - rthallisey + + # + # SIG Storage + # Owns anything related to storage. + # + sig-storage-approvers: + - mhenriks + - alicefr + sig-storage-reviewers: + - awels + - akalenyu + - ShellyKa13 + + # + # SIG API + # Owns the API including API life-cycle, deprecation, + # and backwards compatibility. + # + sig-api-approvers: [] + sig-api-reviewers: [] + + # + # SIG Compute + # Owns everything which is taking place on a node, for example + # (but not limited to) groups, SELinux, node labels, … + # And everything on the cluster level such as RBAC, controller, … + # + sig-compute-approvers: + - jean-edouard + - iholder101 + sig-compute-reviewers: + - victortoso + + # + # SIG Observability + # Owns the responsibility to keep kubevirt observable by i.e. + # having mertics, alters, and runbooks. + # + sig-observability-approvers: + - sradco + - machadovilaca + sig-observability-reviewers: + - machadovilaca + - avlitman + - assafad + + # + # SIG Release + # Owns the release process, including the schedule, and tools. + # + sig-release-approvers: + - acardace + - fossedihelm + - xpivarc + sig-release-reviewers: + - acardace + - fossedihelm + - xpivarc + + # + # SIG Buildsystem + # Owns bazel, and ensures that kubevirt can be build. + # + sig-buildsystem-approvers: + - brianmcarey + - dhiller + - xpivarc + sig-buildsystem-reviewers: + - brianmcarey + - enp0s3 + - xpivarc + + # + # SIG Architecture + # Owns the overall architecture, and supporting the growth, health, + # openess of KubeVirt. + # + sig-architecture-approvers: [] + sig-architecture-reviewers: [] diff --git a/docs/cluster_admin/OWNERS b/docs/cluster_admin/OWNERS new file mode 100644 index 000000000..e9b2cb629 --- /dev/null +++ b/docs/cluster_admin/OWNERS @@ -0,0 +1,8 @@ +filters: + ".*": + reviewers: + - sig-compute-reviewers + approvers: + - sig-compute-approvers + emeritus_approvers: + - emeritus_approvers diff --git a/docs/compute/OWNERS b/docs/compute/OWNERS new file mode 100644 index 000000000..e9b2cb629 --- /dev/null +++ b/docs/compute/OWNERS @@ -0,0 +1,8 @@ +filters: + ".*": + reviewers: + - sig-compute-reviewers + approvers: + - sig-compute-approvers + emeritus_approvers: + - emeritus_approvers diff --git a/docs/debug_virt_stack/OWNERS b/docs/debug_virt_stack/OWNERS new file mode 100644 index 000000000..e9b2cb629 --- /dev/null +++ b/docs/debug_virt_stack/OWNERS @@ -0,0 +1,8 @@ +filters: + ".*": + reviewers: + - sig-compute-reviewers + approvers: + - sig-compute-approvers + emeritus_approvers: + - emeritus_approvers diff --git a/docs/network/OWNERS b/docs/network/OWNERS new file mode 100644 index 000000000..21e9c9769 --- /dev/null +++ b/docs/network/OWNERS @@ -0,0 +1,8 @@ +filters: + ".*": + reviewers: + - sig-network-reviewers + approvers: + - sig-network-approvers + emeritus_approvers: + - emeritus_approvers diff --git a/docs/storage/OWNERS b/docs/storage/OWNERS new file mode 100644 index 000000000..08c6dd565 --- /dev/null +++ b/docs/storage/OWNERS @@ -0,0 +1,8 @@ +filters: + ".*": + reviewers: + - sig-storage-reviewers + approvers: + - sig-storage-approvers + emeritus_approvers: + - emeritus_approvers