needs-approver-review: avoid labelling PRs with changes requested

[dhiller]

What this PR does / why we need it:

GitHub search currently lacks being able to query for PRs that are missing a review by an approver, since the concept of approver vs. reviewer is enforced via OWNERS, which GitHub doesn't know about.

This change adds a condition to the search query that selects PRs to label with needs-approver-review in order to exclude PRs where changes have been requested.

Important

For this to work approvers need to explicitly request changes on the review though

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @jean-edouard @brianmcarey

FYI @vladikr @alicefr

[kubevirt-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[alicefr]

/lgtm

[dhiller]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dhiller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubevirt-bot]

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

• key project-infra-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-periodics.yaml

In response to this:

What this PR does / why we need it:

GitHub search currently lacks being able to query for PRs that are missing a review by an approver, since the concept of approver vs. reviewer is enforced via OWNERS, which GitHub doesn't know about.

This change adds a condition to the search query that selects PRs to label with needs-approver-review in order to exclude PRs where changes have been requested.

[!IMPORTANT]
For this to work approvers need to explicitly request changes on the review though

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @jean-edouard @brianmcarey

FYI @vladikr @alicefr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.