-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release branch presubmits are missing run_before_merge: true
#3478
Comments
Thanks We can either take this PR #3126 - imo it is the best supporting phased on branches wont help because we do need run_before_merge and to consider branch protection |
FYI @xpivarc We need to take that into account next release at the latest! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
This field was added to the main branch presubmit jobs to enable use of the phased plugin - the phased plugin does not target release branches and the
run_before_merge
field is missing from the recent v1.3 presubmit job config[1].This issue can cause backport PRs to merge without having the full suite of CI test lanes run successfully[2].
[1] #3477
[2] https://prow.ci.kubevirt.io/pr-history/?org=kubevirt&repo=kubevirt&pr=12132
The text was updated successfully, but these errors were encountered: