From 08383602799142b53ee6a77171c305f087599259 Mon Sep 17 00:00:00 2001 From: Alex Kalenyuk Date: Sun, 6 Oct 2024 16:39:08 +0300 Subject: [PATCH] Docs for dataimportcron storage class switching (#3445) Signed-off-by: Alex Kalenyuk --- doc/datavolumes.md | 1 + doc/os-image-poll-and-update.md | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/doc/datavolumes.md b/doc/datavolumes.md index c5187ca162..11415ef768 100644 --- a/doc/datavolumes.md +++ b/doc/datavolumes.md @@ -83,6 +83,7 @@ or implicitly as explained in the previous paragraph), CDI will take the file sy overhead into account and request a PVC big enough to fit both an image and the file system metadata. This logic only applies to the `DataVolume.spec.storage`. +#### Default virtualization storage class If you skip the `storageClassName` parameter, CDI will prioritize the default virtualization storage class over k8s' default. You can define your default virtualization storage class by annotating it with diff --git a/doc/os-image-poll-and-update.md b/doc/os-image-poll-and-update.md index 2b6f007f34..7c5345a8cc 100644 --- a/doc/os-image-poll-and-update.md +++ b/doc/os-image-poll-and-update.md @@ -109,3 +109,13 @@ spec: ``` To ensure smooth transition, existing DataImportCrons can be switchd to maintaining snapshots instead of PVCs by updating their corresponding storage profiles. + +## DataImportCron storage class +Unless specified explicitly, similarly to PVCs, DataImportCrons will be provisioned using the default [virt](./datavolumes.md#default-virtualization-storage-class)/k8s storage class. +In previous versions, an admin would have to actively delete the old sources upon change of the storage class +(either explicitly by editing the DataImportCron or a cluster-wide change of the default storage class) + +Today, the controller performs this automatically; +However, changing the storage class should be a conscious decision and in some cases (complex CI setups) it's advised to specify it explicitly +to avoid exercising a different storage class for golden images throughout installation. +This flip flop could be costly and in some cases outright surprising to cluster admins.