Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix typos in community-membership #30

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Docs: fix typos in community-membership #30

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4cdcf39
Docs: fix typos
charlie0129 Jun 8, 2022
24d6643
Docs: fix typos
charlie0129 Jun 8, 2022
1f586d1
Docs: remove unnecessary colons
charlie0129 Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 26 additions & 27 deletions community-membership.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@

All contributors should be welcomed to the community by existing members, helped with PR workflow, and directed to relevant documentation and communication channels.

This table outlines the various responsibilities of contributor roles in
KubeVela.
This table outlines the various responsibilities of contributor roles in KubeVela.

The Apache way says Community Over Code. Although KubeVela is a CNCF/Linux project, we possess a strong resonance to it. To second and stretch this merit deeper, we regard non-coding contribution as equally important for the community's very existence and its future growth. Current core community members will be deciding whereas these non-coding contribution is valid enough to be a Member, Reviewer, Approver or Maintainer.
The Apache way says Community Over Code. Although KubeVela is a CNCF/Linux project, we possess a strong resonance to it. To second and stretch this merit deeper, we regard non-coding contribution as equally important to the community's very existence and its future growth. Current core community members will be deciding whereas these non-coding contribution is valid enough to be a Member, Reviewer, Approver or Maintainer.

| Role | Responsibilities | Requirements | Defined by |
| -----| ---------------- | ------------ | -------|
Expand All @@ -19,20 +18,20 @@ Members are continuously active contributors in the community. They can have iss

### Requirements
- Have made multiple contributions to the project or community.
- **Submitted 1 coding PRs or 3 doc PRs**.
- **Equivalent non-coding devotion, such as Spec model contribution or community management or developer advocate and etc.**
- **Submitted 1 coding PR or 3 doc PRs**.
- **Equivalent non-coding devotion, such as Spec model contribution, community management, developer advocate, and etc.**
- Contribution may include, but is not limited to:
- Authoring or reviewing PRs on GitHub
- Filing or commenting on issues on GitHub
- Contributing to community discussions (e.g. meetings, discussion group)
- **Sponsored by 2 reviewer**
- Contributing to community discussions (e.g. meetings, discussion groups)
- **Sponsored by 2 reviewers**
- **With no objections from other reviewers**
- Done through a issue to request for joining the org
- Done through an issue to request joining the org

### Responsibilities and privileges
- **Be a Member of KubeVela GitHub organization**
- **Being a Member of KubeVela GitHub organization**
- Responsive to issues and PRs assigned to them
- Active owner of code they have contributed (unless ownership is explicitly transferred)
- Active owner of the code they have contributed (unless ownership is explicitly transferred)
- Code is well tested
- Tests consistently pass
- Addresses bugs or issues discovered after code is accepted
Expand All @@ -41,10 +40,10 @@ Members are continuously active contributors in the community. They can have iss
Reviewers are able to review code for quality and correctness. They are knowledgeable about both the codebase and software engineering principles.
### Requirements
- **Primary reviewer for at least 3 PRs to the codebase**
- **Equivalent non-coding devotion, such as Spec model contribution or community management or developer advocate and etc.**
- **Equivalent non-coding devotion, such as Spec model contribution, community management, developer advocate, and etc.**
- Knowledgeable about the codebase
- Triage issue into further steps
- **Sponsored by 2 approver**
- **Sponsored by 2 approvers**
- **With no objections from other approvers**
- Done through PR to update the OWNERS file

Expand All @@ -57,21 +56,21 @@ Reviewers are able to review code for quality and correctness. They are knowledg
- Assigned test bugs related to reviewer's expertise

## Approver
Code approvers are able to both review and approve code contributions. While code review is focused on code quality and correctness, approval is focused on holistic acceptance of a contribution including: backwards / forwards compatibility, adhering to API and flag conventions, subtle performance and correctness issues, interactions with other parts of the system, etc.
Also they are on charge of certain product area in KubeVela.
Code approvers are able to both review and approve code contributions. While code review is focused on code quality and correctness, approval is focused on holistic acceptance of a contribution, including backwards / forwards compatibility, adhering to API and flag conventions, subtle performance and correctness issues, interactions with other parts of the system, and etc.
They are also on charge of certain areas in KubeVela.

### Requirements
- **Primary reviewer for 20 substantial effort/large labled PRs to the codebase**
- **Equivalent non-coding devotion, such as Spec model contribution or community management or developer advocate and etc.**
- **Sponsored by 2 maintainer**
- **Primary reviewer for 20 substantial effort/large labelled PRs to the codebase**
- **Equivalent non-coding devotion, such as Spec model contribution, community management, developer advocate, and etc.**
- **Sponsored by 2 maintainers**
- **With no objections from other maintainer**
- Done through PR to update the OWNERS file

### Responsibilities and privileges
- Demonstrate sound technical judgement
- Triage issue into further steps
- Responsible for project quality control
- Focus on holistic acceptance of contribution such as dependencies with other features, backwards / forwards compatibility, API and flag definitions, etc
- Focus on holistic acceptance of contributions, such as dependencies with other features, backwards / forwards compatibility, API and flag definitions, and etc
- Expected to be responsive to review requests
- Mentor members and reviewers

Expand All @@ -83,9 +82,9 @@ The Maintainers are typically limited to a relatively small group of decision ma
- Sustained contributions to design and direction by doing all of:
- Authoring and reviewing proposals
- Initiating, contributing and resolving discussions (emails, GitHub issues, meetings)
- Identifying subtle or complex issues in designs and implementation PRs
- **Equivalent non-coding devotion, such as Spec model contribution or community management or developer advocate and etc.**
- **Sponsored by majority vote(2/3) of maintainers**
- Identifying subtle or complex issues in designs and their implementation PRs
- **Equivalent non-coding devotion, such as Spec model contribution, community management, developer advocate, and etc.**
- **Sponsored by the majority of maintainers (2/3)**

### Responsibilities and privileges
- Make and approve technical design decisions
Expand All @@ -95,17 +94,17 @@ The Maintainers are typically limited to a relatively small group of decision ma
- Ensure continued health of project
- Adequate test coverage to confidently release
- Tests are passing reliably (i.e. not flaky) and are fixed when they fail
- Ensure a healthy process for discussion and decision making is in place.
- Ensure a healthy process for discussions and decision-making is in place.
- Work with other owners to maintain the project's overall health and success holistically

## Inactive members

A core principle in maintaining a healthy community is encouraging active
participation. It is inevitable that people's focuses will change over time and
participation. It is inevitable that people's focuses will change over time, and
they are not expected to be actively contributing forever.

Therefore members with an extended period away from the project with no activity
will be removed from the KubeVela Github Organizations and will be required to
Therefore, members with an extended period away from the project with no activity
will be removed from the KubeVela GitHub Organizations and will be required to
go through the org membership process again after re-familiarizing themselves
with the current state.

Expand All @@ -116,10 +115,10 @@ Inactive members are defined as members of one of the KubeVela Organizations
with **no** contributions across any organization within **6 months**. This is
measured by the CNCF [DevStats project].

**Note:** Devstats does not take into account non-code contributions. If a
**Note:** DevStats does not take into account non-code contributions. If a
non-code contributing member is accidentally removed this way, they may open an
issue to quickly be re-instated.

After an extended period away from the project with no activity
After an extended period away from the project with no activity,
those members would need to re-familiarize themselves with the current state
before being able to contribute effectively.