Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test description updates in UI are not persisted #3888

Closed
gberche-orange opened this issue May 24, 2023 · 4 comments · Fixed by #4293
Closed

Test description updates in UI are not persisted #3888

gberche-orange opened this issue May 24, 2023 · 4 comments · Fixed by #4293
Assignees
Labels
feature-request 🚀 New feature request service:dashboard 🎡 Testkube Web Dashboard

Comments

@gberche-orange
Copy link
Contributor

Describe the bug

Seems that the Test description feature is not currently implemented in the backend, and therefore dashboard requests to update it are noop

To Reproduce
Steps to reproduce the behavior:

  1. Update the description for a test
    image

  2. Reload the page: no description is displayed
    image

The API request sets executionRequest.description in the REST API, but this field is not available in the swager schema associated to create request https://docs.testkube.io/openapi/#tag/api/operation/createTest

image

Also no description field in the CRD https://github.com/kubeshop/helm-charts/blob/main/charts/testkube-operator/templates/tests.testkube.io_tests.yaml#L445-L445

Expected behavior

Ability to set and display test descriptions

Version / Cluster

  • Which testkube version? 1.11.220
  • What Kubernetes cluster? (e.g. GKE, EKS, Openshift etc, local KinD, local Minikube)
  • What Kubernetes version?
@gberche-orange gberche-orange added the bug 🐛 Something is not working as should be label May 24, 2023
@vsukhin vsukhin added this to Testkube May 24, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Testkube May 24, 2023
@vsukhin
Copy link
Collaborator

vsukhin commented May 24, 2023

@gberche-orange yes, we don't have this field. should we add it @aabedraba @TheBrunoLopes

@vsukhin vsukhin added the feature-request 🚀 New feature request label May 24, 2023
@aabedraba
Copy link

@gberche-orange thanks for the bug report!

@vsukhin we should definitely add!

@vsukhin vsukhin self-assigned this May 29, 2023
@vsukhin vsukhin moved this from 🆕 New to 🏗 In progress in Testkube May 29, 2023
@aabedraba aabedraba moved this from 🏗 In progress to 🔖 Ready in Testkube May 30, 2023
@TheBrunoLopes TheBrunoLopes added the service:dashboard 🎡 Testkube Web Dashboard label Jun 6, 2023
@vsukhin vsukhin removed the bug 🐛 Something is not working as should be label Jun 21, 2023
@pavloburchak
Copy link

@vsukhin any update on this one?

@vsukhin
Copy link
Collaborator

vsukhin commented Jul 25, 2023

Low priority for now

@vsukhin vsukhin moved this from 🔖 Ready to 🏗 In progress in Testkube Aug 23, 2023
@vsukhin vsukhin moved this from 🏗 In progress to 👀 In review in Testkube Aug 24, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Testkube Aug 24, 2023
@vsukhin vsukhin moved this from ✅ Done to QA in Testkube Aug 28, 2023
@tkonieczny tkonieczny moved this from QA to ✅ Done in Testkube Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request 🚀 New feature request service:dashboard 🎡 Testkube Web Dashboard
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants