Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only init container data for all pre-built executors #3405

Closed
vsukhin opened this issue Mar 14, 2023 · 1 comment · Fixed by #3768
Closed

Use only init container data for all pre-built executors #3405

vsukhin opened this issue Mar 14, 2023 · 1 comment · Fixed by #3768
Assignees

Comments

@vsukhin
Copy link
Collaborator

vsukhin commented Mar 14, 2023

Why should it be implemented?
Some of our pre-built executors still have its own git checkout and don't use init container data

Describe the improvement
Start using init container data for all pre-built executors

@vsukhin vsukhin added this to Testkube Mar 14, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Testkube Mar 14, 2023
@TheBrunoLopes TheBrunoLopes moved this from 🆕 New to 🔖 Ready in Testkube Apr 18, 2023
@vsukhin vsukhin self-assigned this Apr 18, 2023
@vsukhin vsukhin moved this from 🔖 Ready to 🏗 In progress in Testkube May 3, 2023
@vsukhin vsukhin moved this from 🏗 In progress to 👀 In review in Testkube May 8, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Testkube May 9, 2023
@vsukhin vsukhin moved this from ✅ Done to QA in Testkube May 9, 2023
@tkonieczny
Copy link
Contributor

🔬 Executing in directory /data/repo: 
 $ /bin/sh /usr/local/SmartBear/EntryPoint.sh /data/repo/test/soapui/executor-smoke/soapui-smoke-test.xml
❌ Execution failed: could not start process with command: /bin/sh /usr/local/SmartBear/EntryPoint.sh  error: fork/exec /bin/sh /usr/local/SmartBear/EntryPoint.sh: no such file or directory
output: 
Scraping directories: [/home/soapui/.soapuios/logs]
could not start process with command: /bin/sh /usr/local/SmartBear/EntryPoint.sh  error: fork/exec /bin/sh /usr/local/SmartBear/EntryPoint.sh: no such file or directory
output: 
running test [64774012f0a92ef6340cf028]
🚚 Running with config [scraperEnabled true dataDir /data SSL false endpoint testkube-minio-service-testkube:9000]
🌍 It is a directory test - trying to find file from the last executor argument test/jmeter/executor-tests/jmeter-executor-smoke.jmx in directory /data/repo
❌ Could not find file test/jmeter/executor-tests/jmeter-executor-smoke.jmx in the directory, error: stat /data/repo/data/repo/test/jmeter/executor-tests/jmeter-executor-smoke.jmx: no such file or directory
could not find file test/jmeter/executor-tests/jmeter-executor-smoke.jmx in the directory: stat /data/repo/data/repo/test/jmeter/executor-tests/jmeter-executor-smoke.jmx: no such file or directory
apiVersion: tests.testkube.io/v3
kind: Test
metadata:
  name: jmeter-executor-smoke-directory
  namespace: testkube
  labels:
    core-tests: executors
    executor: jmeter-executor
    test-type: jmeter-test
spec:
  type: jmeter/test
  content:
    type: git
    repository:
      type: git
      uri: https://github.com/kubeshop/testkube.git
      branch: main
      path: test/jmeter/executor-tests
  executionRequest:
    args:
      - "jmeter-executor-smoke.jmx"
  • K6, directory is now consistent with other executors - duplicated path isn't needed anymore ✔️

@tkonieczny tkonieczny reopened this May 31, 2023
@github-project-automation github-project-automation bot moved this from QA to 📋 Backlog in Testkube May 31, 2023
@vsukhin vsukhin closed this as completed Jun 2, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Testkube Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants