Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm values to allow resource specification for all components #2943

Closed
crdnb opened this issue Dec 22, 2022 · 4 comments
Closed

Add helm values to allow resource specification for all components #2943

crdnb opened this issue Dec 22, 2022 · 4 comments
Assignees

Comments

@crdnb
Copy link

crdnb commented Dec 22, 2022

Describe the enhancement you'd like to see
Testkube is great and the helm values allow to configure many options already. For lots of components it is already possible to specify resources (cpu and memory limits and requests).

For the following components / pods there is no resource configuration possible within helm values at the moment (or at least I did not find it):

  • pod "release-name-nats-test-request-reply"
  • pod "testkube-api-server-test-connection"
  • pod "testkube-operator-test-connection"
  • sts "release-name-nats"
  • deployment "release-name-nats-box"
  • deployment "testkube-minio-col-testkube-test"
  • deployment "testkube-operator-controller-manager"
  • job "webhook-cert-patch"
  • job "webhook-cert-create"
  • job "mongodb-upgrade"
  • jobtemplate for executor jobs
  • jobtemplate for scraper jobs

It would be great to have the ability to configure compute resources also on these components, so that Testkube would also run on clusters where resource specification is mandatory.

Thank you very much for your great work!

@ypoplavs ypoplavs self-assigned this Dec 22, 2022
@vsukhin vsukhin moved this to 🆕 New in Testkube Dec 22, 2022
@vsukhin vsukhin added this to Testkube Dec 22, 2022
@vsukhin vsukhin moved this from 🆕 New to 🔖 Ready in Testkube Dec 22, 2022
@vsukhin vsukhin moved this from 🔖 Ready to 🏗 In progress in Testkube Dec 22, 2022
@vsukhin
Copy link
Collaborator

vsukhin commented Dec 22, 2022

thank you @crdnb totally makes sense. we also need to check that all of them are used, jobtemplate for executors are already supported by Test CRD, sounds like we need to add a CRD field for scraper template

@vsukhin vsukhin self-assigned this Dec 22, 2022
@vsukhin vsukhin removed their assignment Jan 3, 2023
@ypoplavs
Copy link
Collaborator

ypoplavs commented Jan 4, 2023

Hello @crdnb,

We have added an option for resource specifications for the missing Testkube components. However, we rely on an external NATS chart that can be accustomed to your needs with --set option. You can provide your own values for sts and deployment entities, however the option is missing for test-request-reply pod. I opened an issue to add that: nats-io/k8s#627

Please let us know in case of any issues.

@crdnb
Copy link
Author

crdnb commented Jan 4, 2023

Hi @ypoplavs

Thank you so much for adding the options and for opening the issue for the nats components!

Minio resouce definition is working now.

Currently I'm still facing problems with specifying resources on the proxy container of the testkube-operator-controller-manager pod. Can you tell me how to specify the resources for this container please?

The webhook and mongodb jobs are also working now.

For test jobs I'm defining the resources via job-template currently, as I don't know a helm value to set their resources yet. Is this still the way to go?

Thank you!

@ypoplavs
Copy link
Collaborator

ypoplavs commented Jan 6, 2023

Hello @crdnb,
We have updated proxy container of the testkube-operator-controller-manager pod so now you can find resource specification here:

testkube-operator:
  proxy:
    resources: {}

Please try and let me know about the results.

As for test jobs - yes, you have to define them via job-template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants