Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test, testsuite operations atomic #1998

Closed
nicufk opened this issue Aug 4, 2022 · 5 comments
Closed

Make test, testsuite operations atomic #1998

nicufk opened this issue Aug 4, 2022 · 5 comments
Assignees
@nicufk
Labels
bug 🐛 Something is not working as should be enhancement New feature or request tech-debt 🙈

Comments

@nicufk
Copy link
Contributor

nicufk commented Aug 4, 2022

Describe the enhancement you'd like to see
Now for example if there is an error in deleting a test it won't delete it secrets but the test is deleted.

Additional context
Add any other context, CLI input/output, etc. about the enhancement here.
@nicufk nicufk added the enhancement New feature or request label Aug 4, 2022
@TheBrunoLopes TheBrunoLopes moved this to 🆕 New in Testkube Aug 4, 2022
@exu exu added the bug 🐛 Something is not working as should be label Aug 23, 2022
@exu exu moved this from 🆕 New to 🔖 Ready in Testkube Aug 23, 2022
@vsukhin
Copy link
Collaborator

vsukhin commented Aug 24, 2022

We should have a kind of Saga for this. Compensate failed operations with reverse ones

@nicufk nicufk self-assigned this Aug 24, 2022
@exu
Copy link
Member

exu commented Sep 12, 2022

Can't controller handle those for CRD's? during delete remove all deps?

@nicufk nicufk moved this from 🔖 Ready to 🏗 In progress in Testkube Sep 15, 2022
@nicufk nicufk moved this from 🏗 In progress to 🔖 Ready in Testkube Sep 27, 2022
@exu exu unassigned nicufk Nov 2, 2022
@vsukhin
Copy link
Collaborator

vsukhin commented Nov 29, 2022

We need to define each operation to support

@kubeshop kubeshop deleted a comment from vsukhin Nov 29, 2022
@TheBrunoLopes
Copy link
Member

@vsukhin is this still an issue ?

@vsukhin
Copy link
Collaborator

vsukhin commented Apr 13, 2023

we didn't wrok on this issue

@nicufk nicufk self-assigned this May 3, 2023
@nicufk nicufk moved this from 🔖 Ready to 🏗 In progress in Testkube May 3, 2023
This was referenced May 10, 2023
Merged
Merged
@nicufk nicufk moved this from 🏗 In progress to ✅ Done in Testkube Jun 22, 2023
@nicufk nicufk closed this as completed Jun 22, 2023
@vsukhin vsukhin moved this from ✅ Done to QA in Testkube Jun 28, 2023
@vsukhin vsukhin moved this from QA to ✅ Done in Testkube Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicufk nicufk

Labels
bug 🐛 Something is not working as should be enhancement New feature or request tech-debt 🙈
Projects
Testkube
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@exu @vsukhin @TheBrunoLopes @nicufk