Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KubeletConfig doc to reference the release-1.9 code base #7696

Merged
merged 1 commit into from
Mar 14, 2018
Merged

Update KubeletConfig doc to reference the release-1.9 code base #7696

merged 1 commit into from
Mar 14, 2018

Conversation

cimomo
Copy link
Contributor

@cimomo cimomo commented Mar 9, 2018

The API version has been bumped up to v1beta1 in the master branch.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Mar 9, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit aa16531

https://deploy-preview-7696--kubernetes-io-master-staging.netlify.com

@mtaufen
Copy link
Contributor

mtaufen commented Mar 9, 2018

Lol this is something like the fifth one of these I've had to comment on... the changes were already made on the release-1.10 branch in #7561 and will be released alongside the official Kubernetes release.

@cimomo
Copy link
Contributor Author

cimomo commented Mar 9, 2018

@mtaufen LOL, so that you won't have to comment on more of these, how about we point this to release-1.9 to fix the broken reference that's on the live document site. It will be updated to v1beta1 with your change when v1.10 gets released and the doc always stays consistent.

@mtaufen
Copy link
Contributor

mtaufen commented Mar 9, 2018

That sgtm.

@mtaufen
Copy link
Contributor

mtaufen commented Mar 9, 2018

Please also update the PR title/text and squash commits.

tengqm
tengqm approved these changes Mar 10, 2018
View reviewed changes
Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2018
@cimomo cimomo changed the title Update KubeletConfig doc to reference the v1beta1 API Update KubeletConfig doc to reference the release-1.9 code base Mar 10, 2018
@cimomo
Point the KubeletConfig doc to the release-1.9 code base
aa16531 
The version will be updated to v1beta1 with the official 1.10 release.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2018
@cimomo
Copy link
Contributor Author

cimomo commented Mar 10, 2018

@mtaufen Sure ... updated the PR message and squashed the commits.

@cimomo
Copy link
Contributor Author

cimomo commented Mar 12, 2018

/assign @zacharysarah

@mtaufen
Copy link
Contributor

mtaufen commented Mar 12, 2018

@tengqm should this merge to master or to the release-1.9 branch?

@tengqm
Copy link
Contributor

tengqm commented Mar 13, 2018

@mtaufen I believe this (link fix) should go to the master branch.

@mtaufen
Copy link
Contributor

mtaufen commented Mar 13, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2018
@cimomo
Copy link
Contributor Author

cimomo commented Mar 13, 2018

@zacharysarah Please approve. Thanks!

@mtaufen mtaufen mentioned this pull request Mar 13, 2018
Closed
@cimomo
Copy link
Contributor Author

cimomo commented Mar 14, 2018

/assign @heckj

@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtaufen, tengqm, zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1549d29 into kubernetes:master Mar 14, 2018
@cimomo cimomo deleted the kubeletconfig-fix branch March 16, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm approved these changes

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@heckj heckj

@mtaufen mtaufen

@zacharysarah zacharysarah

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cimomo @k8sio-netlify-preview-bot @mtaufen @tengqm @zacharysarah @k8s-ci-robot @heckj