-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Documentation for custom pod DNS alpha feature #6408
Conversation
Ref feature issue: kubernetes/enhancements#504 |
Deploy preview ready! Built with commit b9866aa https://deploy-preview-6408--kubernetes-io-vnext-staging.netlify.com |
@tengqm Thanks for the works, your PR looks great. Just that it is targeting master branch instead of release-1.9 branch. Would you mind changing it (or opening a new one) to target release-1.9 and I will close this one? |
@MrHohn Thanks for the comments. My intent when drafting #6441 was to make it general. It highlights v1.9 when appropriate so it won't cause confusion. I'm looking forward it to be merged into master and then picked into release-1.9. I tried proposing directly to release-1.9 branch previously, there were some conflicts to solve. @zacharysarah WDYT? |
@zacharysarah I'm a bit confused about the work flow. My previous understanding is that all PRs are supposed to be part of the master branch. If a PR is specifically about a release, it will be cherry-picked into that branch. However, you are suggesting that we propose a PR to release-1.9 directly. Does that mean the release-1.9 contents will be merged back to master again at some time? |
@zacharysarah I have just committed #6479, although I'm still confused. |
@tengqm Thanks. 🙇
I think the confusion may arise from the fact that kubernetes/website uses In other dev repos, commits to master:
In kubernetes/website, changes to master:
Commits to a new release branch are deployed on k8s.io with a version selector when a new version of Kubernetes goes live. The reason why I'm asking you to base PRs containing information about 1.9 to
No; Does that help? |
Thanks all, I'm closing this in favor of #6479. |
Ah ... finally, I get it! A big thank you, @zacharysarah. |
Need to document:
None
for pod.This change is