Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed lt and gt as operators #4152

Merged
merged 3 commits into from
Jun 22, 2017
Merged

removed lt and gt as operators #4152

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77c589c
removed lt and gt as operators
mburke5678 Jun 21, 2017
e2eb1ac
replace lt and gt for node-affinfity
mburke5678 Jun 21, 2017
49d95f5
updated based on bsalamat review
mburke5678 Jun 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/concepts/configuration/assign-pod-node.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ label having key "security" and value "S2".) See the [design doc](https://github
for many more examples of pod affinity and anti-affinity, both the `requiredDuringSchedulingIgnoredDuringExecution`
flavor and the `preferredDuringSchedulingIgnoredDuringExecution` flavor.

As with node affinity, the legal operators for pod affinity and anti-affinity are `In`, `NotIn`, `Exists`, `DoesNotExist`, `Gt`, `Lt`.
As with node affinity, the legal operators for pod affinity and anti-affinity are `In`, `NotIn`, `Exists`, `DoesNotExist`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure As with node affinity fits now as node affinities and pod affinities operators are not same.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @aveshagarwal mentioned, node affinity supports "Gt" and "Lt" as well. Pod affinity term uses standard label selectors which support only In, NotIn, Exists, and DoesNotExist. So, please remove As with node affinity, .


In principle, the `topologyKey` can be any legal label value. However,
for performance reasons, only a limited set of topology keys are allowed.
Expand Down