Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LegacyServiceAccountTokenCleanUp feature in alpha; move LegacyServiceAccountTokenTracking to GA #41341

Merged
merged 1 commit into from
May 31, 2023
Merged

Add LegacyServiceAccountTokenCleanUp feature in alpha; move LegacyServiceAccountTokenTracking to GA #41341

merged 1 commit into from
May 31, 2023

Conversation

yt2985
Copy link
Contributor

@yt2985 yt2985 commented May 26, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added this to the 1.28 milestone May 26, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 26, 2023
@k8s-ci-robot k8s-ci-robot requested review from kbhawkey and onlydole May 26, 2023 17:11
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 26, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @yt2985!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 26, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 26, 2023
@yt2985 yt2985 changed the title Add LegacyServiceAccountTokenCleanUp feature in alpha. Add LegacyServiceAccountTokenCleanUp feature in alpha and Update LegacyServiceAccountTokenTracking to GA. May 26, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 26, 2023
@zshihang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 45bf8209d860369a65022c6253960c8874fe0848

@zshihang zshihang mentioned this pull request May 26, 2023
Closed
39 tasks
@sftim
Copy link
Contributor

sftim commented May 27, 2023

/retitle Add LegacyServiceAccountTokenCleanUp feature in alpha; move LegacyServiceAccountTokenTracking to GA

@k8s-ci-robot k8s-ci-robot changed the title Add LegacyServiceAccountTokenCleanUp feature in alpha and Update LegacyServiceAccountTokenTracking to GA. Add LegacyServiceAccountTokenCleanUp feature in alpha; move LegacyServiceAccountTokenTracking to GA May 27, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023
@k8s-ci-robot k8s-ci-robot requested a review from zshihang May 30, 2023 17:16
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2023
@yt2985 yt2985 force-pushed the dev-1.28 branch 2 times, most recently from cc80fc1 to 4821cbe Compare May 30, 2023 17:21
tengqm
tengqm reviewed May 31, 2023
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated
[service account tokens](/docs/reference/access-authn-authz/authentication/#service-account-tokens).
[service account tokens](/docs/concepts/security/service-accounts/#get-a-token).
- `LegacyServiceAccountTokenCleanUp`: Clean up Secret-based
[service account tokens](/docs/concepts/security/service-accounts/#get-a-token).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this "clean up" means to end users?
Is this really a user aware implementation change?

Copy link
Contributor Author

@yt2985 yt2985 May 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this "clean up" means to end users?
Is this really a user aware implementation change?

When this feature is default to be enabled in beta, those automatically generated service account token will be deleted if they are not been used for a time period (default to be one year). Please refer to
[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/2799-reduction-of-secret-based-service-account-token for the rationale and kubernetes/kubernetes#115554 for the implementation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. I believe this clarification could be incorporated into the feature description, or else people like me may treat it as an implementation clean up rather than token clean up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, as someone who is too bandwidth limited to check the design or the source code, I'd suggest we articulate user perceivable changes clearly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Qiming. I updated the feature description.

@yt2985 yt2985 force-pushed the dev-1.28 branch 3 times, most recently from 2da1b4c to 10f2444 Compare May 31, 2023 05:22
@tengqm
Copy link
Contributor

tengqm commented May 31, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c60e1299671d75be7f757ba55ca150e25554e97a

@sftim
Copy link
Contributor

sftim commented May 31, 2023

Thanks

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 884bf0b into kubernetes:dev-1.28 May 31, 2023
@Rishit-dagli
Copy link
Member

Rishit-dagli commented Jul 24, 2023 •
edited
Loading

Hey @yt2985 @zshihang , This docs PR was merged but the associated KEP was then deferred to 1.28, so I think we would want to revert this and then make the feature gates changes when this lands in 1.29?

cc: @sftim

Ref: Slack Discussion on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@tengqm tengqm tengqm left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@onlydole onlydole Awaiting requested review from onlydole

@zshihang zshihang Awaiting requested review from zshihang

Assignees

@tengqm tengqm

@zshihang zshihang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.28
Development

Successfully merging this pull request may close these issues.
6 participants
@yt2985 @k8s-ci-robot @zshihang @sftim @tengqm @Rishit-dagli