Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update LegacyServiceAccountTokenTracking to beta #40066

Merged
merged 1 commit into from
Mar 31, 2023
Merged

update LegacyServiceAccountTokenTracking to beta #40066

merged 1 commit into from
Mar 31, 2023

Conversation

zshihang
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added this to the 1.27 milestone Mar 16, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 16, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: zshihang / name: Shihang Zhang (8212bf1)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 16, 2023
@k8s-ci-robot k8s-ci-robot requested review from onlydole and sftim March 16, 2023 21:27
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2023
@zshihang zshihang mentioned this pull request Mar 16, 2023
Closed
39 tasks
@zshihang zshihang marked this pull request as ready for review March 16, 2023 21:34
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2023
sftim
sftim reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make any update to https://kubernetes.io/docs/concepts/security/service-accounts/? Or maybe https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/?

Arhell
Arhell reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign CLA

@mickeyboxell
Copy link
Contributor

Hi @zshihang 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review as soon as possible. 01:00 UTC Wednesday 22nd March 2023 / 17:00 PDT Tuesday 21st March 2023 is the official deadline.

This PR will need a doc review by Tuesday 4th April 2023 to get this into the release. Please reach out to required SIGs to get their review. Thank you!

@liggitt
Copy link
Member

liggitt commented Mar 21, 2023

/lgtm
/sig auth

@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1fca1d11bafaf6aec05d0b023cd8395c77e788dc

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot k8s-ci-robot requested a review from liggitt March 21, 2023 16:08
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 21, 2023
@tengqm
Copy link
Contributor

tengqm commented Mar 22, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@tengqm
Copy link
Contributor

tengqm commented Mar 31, 2023

/lgtm
(reapplied)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c6bc9e543133938282dd0637434f68ded8aa1f7b

@k8s-ci-robot k8s-ci-robot merged commit 21d04ff into kubernetes:dev-1.27 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@sftim sftim sftim left review comments

@onlydole onlydole Awaiting requested review from onlydole

@bradtopol bradtopol Awaiting requested review from bradtopol

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.27
Development

Successfully merging this pull request may close these issues.
7 participants
@zshihang @mickeyboxell @liggitt @k8s-ci-robot @tengqm @sftim @Arhell