Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blog for local storage capacity isolation GA #36025

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Blog for local storage capacity isolation GA #36025

merged 1 commit into from
Sep 19, 2022

Conversation

jingxu97
Copy link
Contributor

blog for GA feature local storage capacity isolation

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 16, 2022
@jingxu97 jingxu97 marked this pull request as ready for review August 16, 2022 19:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 16, 2022
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot requested review from sftim August 16, 2022 19:02
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 16, 2022
nitishfy
nitishfy reviewed Aug 16, 2022
View reviewed changes
content/en/blog/_posts/2022-08-15-local-storage-capacity-isolation-ga.md Outdated

This project, like all of Kubernetes, is the result of hard work by many contributors from diverse backgrounds working together.

We offer a huge thank you to all the contributors in Kubernetes Storage SIG and CSI community who helped review the design and implementation of the project, including but not limited to the following:</p><ul><li>Benjamin Elder (<a href=https://github.com/BenTheElder>BenTheElder</a>)</li><li>Michelle Au (<a href=https://github.com/msau42>msau42</a>)</li><li>Tim Hockin (<a href=https://github.com/thockin>thockin</a>)</li><li>Jordan Liggitt (<a href=https://github.com/liggitt>liggitt</a>)</li><li>Xing Yang (<a href=https://github.com/xing-yang>xing-yang</a>)</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who helped 'to' review the design

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eliding the “to” is common in US English. I think that's fine for a blog article.

@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 343c910
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/632406fbabb8b600088c7f87
😎 Deploy Preview https://deploy-preview-36025--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jingxu97
Copy link
Contributor Author

/assign @xing-yang

@jingxu97 jingxu97 mentioned this pull request Aug 16, 2022
Closed
@AnaMMedina21
Copy link
Member

Hi from Comms team 👋🏽
Thanks for getting the blog PR in!
We are planning to publish your blog post on September 19, 2022. Let us know if you have any questions

divya-mohan0209
divya-mohan0209 reviewed Aug 17, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, hope you find them useful.

content/en/blog/_posts/2022-08-15-local-storage-capacity-isolation-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-15-local-storage-capacity-isolation-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-15-local-storage-capacity-isolation-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-15-local-storage-capacity-isolation-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-15-local-storage-capacity-isolation-ga.md Outdated Show resolved Hide resolved
xing-yang
xing-yang reviewed Aug 18, 2022
View reviewed changes
content/en/blog/_posts/2022-08-15-local-storage-capacity-isolation-ga.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-15-local-storage-capacity-isolation-ga.md Outdated

Similar to CPU and memory, admin could use LimitRange to set default container’s local storage request/limit, and/or minimum/maximum resource constraints for a namespace.

Also, ephemeral-storage may be specified to reserve for kubelet or system. example, --system-reserved=[cpu=100m][,][memory=100Mi][,][ephemeral-storage=1Gi][,][pid=1000] --kube-reserved=[cpu=100m][,][memory=100Mi][,][ephemeral-storage=1Gi][,][pid=1000]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this "reserve" work together with those requests/limits mentioned above? Can you add some explanation in the blog?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added more information there. PTAL

content/en/blog/_posts/2022-08-15-local-storage-capacity-isolation-ga.md Outdated

This project, like all of Kubernetes, is the result of hard work by many contributors from diverse backgrounds working together.

We offer a huge thank you to all the contributors in Kubernetes Storage SIG and CSI community who helped review the design and implementation of the project, including but not limited to the following:</p><ul><li>Benjamin Elder (<a href=https://github.com/BenTheElder>BenTheElder</a>)</li><li>Michelle Au (<a href=https://github.com/msau42>msau42</a>)</li><li>Tim Hockin (<a href=https://github.com/thockin>thockin</a>)</li><li>Jordan Liggitt (<a href=https://github.com/liggitt>liggitt</a>)</li><li>Xing Yang (<a href=https://github.com/xing-yang>xing-yang</a>)</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a hyper link to https://github.com/kubernetes/community/tree/master/sig-storage?

@nitishfy
Copy link
Member

@jingxu97 Please go through the changes that @divya-mohan0209 and @xing-yang mentioned.

@Sea-n
Copy link
Member

Sea-n commented Aug 30, 2022

Hey @jingxu97,

It's been a while since the last update, would you like to address issues in the previous comments so that we can move forward?

sftim
sftim reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jingxu97 we'd love to publish this article, but we'd need updates to this article as soon as you can make them.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2022
@jingxu97
Copy link
Contributor Author

@jingxu97 we'd love to publish this article, but we'd need updates to this article as soon as you can make them.

@sftim, very sorry for the delay. I addressed the comments, PTAL. Thank you!

@jingxu97
Blog for local storage capacity isolation GA
343c910 
blog for GA feature local storage capacity isolation
@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 65d8a082f6a0d0e8c13a950f06ef86681ca6eb62

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit dc8299c into kubernetes:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitishfy nitishfy nitishfy left review comments

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@xing-yang xing-yang xing-yang left review comments

@onlydole onlydole Awaiting requested review from onlydole

@sftim sftim Awaiting requested review from sftim

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jingxu97 @AnaMMedina21 @nitishfy @Sea-n @xing-yang @k8s-ci-robot @reylejano @divya-mohan0209 @sftim