Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Translate the glossary term 'CIDR' into Korean #35359

Merged
merged 1 commit into from
Aug 3, 2022
Merged

[ko] Translate the glossary term 'CIDR' into Korean #35359

merged 1 commit into from
Aug 3, 2022

Conversation

bart2001
Copy link
Contributor

Resolves #35279

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2022
@k8s-ci-robot k8s-ci-robot added the language/ko Issues or PRs related to Korean language label Jul 25, 2022
@k8s-ci-robot k8s-ci-robot requested a review from yoonian July 25, 2022 12:30
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 25, 2022
yoonian
yoonian reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@yoonian yoonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart2001 Thanks for your contribution, and please check my comments. 😄

content/ko/docs/reference/glossary/cidr.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/cidr.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/cidr.md Outdated Show resolved Hide resolved
@bart2001
Copy link
Contributor Author

@yoonian 코멘트 감사합니다.
능동적 표현으로 모두 수정하였습니다^^

yoonian
yoonian reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@yoonian yoonian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart2001 Thanks for your consideration. One more, please.

content/ko/docs/reference/glossary/cidr.md Outdated Show resolved Hide resolved
content/ko/docs/reference/glossary/cidr.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Jul 29, 2022
@yoonian
Copy link
Contributor

yoonian commented Jul 29, 2022 •
edited
Loading

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d230d8172129f405ba6c7997b07bfe2e9b3a01e

@yoonian
Copy link
Contributor

yoonian commented Jul 29, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

@bart2001: The label(s) /label tide cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

@yoonian 님 혹시 의도하신 커맨드가 아래인걸까요? 한줄로 잘못쓰신 것 같아서요ㅎ

/label tide
/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yoonian
Copy link
Contributor

yoonian commented Jul 31, 2022

@bart2001 스퀴싱이 필요한 PR이라 표기한 것입니다. 본 PR에 관련해서 여기를 참조하시면 좋을듯 합니다.

@seokho-son
Copy link
Member

/hold

@bart2001

해당 PR은 base branch가 kubernetes:dev-1.24-ko.1 로 설정되어 있습니다. :)
kubernetes:dev-1.24-ko.2 로 변경을 요청 드립니다. :)

  • 피쳐브랜치의 base도 ko.2이어야 하고, 피쳐브랜치를 머지하려는 타겟 브랜치(이 설정은 PR 제목 옆에 edit를 누르면 설정 가능합니다.)도 ko.2이어야 합니다.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022
@bart2001 bart2001 changed the base branch from dev-1.24-ko.1 to dev-1.24-ko.2 August 2, 2022 13:21
@bart2001 bart2001 force-pushed the feature/35357-cidr branch 2 times, most recently from 6084a4d to 6ef0d98 Compare August 2, 2022 13:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@k8s-ci-robot k8s-ci-robot requested a review from yoonian August 2, 2022 13:39
jihoon-seo
jihoon-seo reviewed Aug 2, 2022
View reviewed changes
content/ko/docs/reference/glossary/cidr.md Outdated
Comment on lines 17 to 18
쿠버네티스에서는 CIDR을 사용하여 시작 주소와 서브넷 마스크로 각 {{<glosary_tooltip text="노드" term_id="node" >}}에 IP 주소 범위를 할당한다.
이를 통해 노드는 각 {{<glosary_tooltip text="파드" term_id="pod" >}}에 고유한 IP 주소를 할당할 수 있다. 원래 IPv4를 위한 개념이었지만 CIDR은 IPv6도 포함하도록 확장됐다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bart2001 님~~ 오타가 있어 빌드가 실패했습니다. 😊

Suggested change
쿠버네티스에서는 CIDR을 사용하여 시작 주소와 서브넷 마스크로 각 {{<glosary_tooltip text="노드" term_id="node" >}}에 IP 주소 범위를 할당한다.
이를 통해 노드는 각 {{<glosary_tooltip text="파드" term_id="pod" >}}에 고유한 IP 주소를 할당할 수 있다. 원래 IPv4를 위한 개념이었지만 CIDR은 IPv6도 포함하도록 확장됐다.
쿠버네티스에서는 CIDR을 사용하여 시작 주소와 서브넷 마스크로 각 {{< glossary_tooltip text="노드" term_id="node" >}}에 IP 주소 범위를 할당한다.
이를 통해 노드는 각 {{< glossary_tooltip text="파드" term_id="pod" >}}에 고유한 IP 주소를 할당할 수 있다. 원래 IPv4를 위한 개념이었지만 CIDR은 IPv6도 포함하도록 확장됐다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoon-seo 님 감사합니다!
지훈님 코멘트 못보고 한참 헤맸네요!
수정하였습니다

@bart2001 bart2001 force-pushed the feature/35357-cidr branch from 6ef0d98 to ccd2415 Compare August 2, 2022 13:57
@jihoon-seo
Copy link
Member

감사합니다!
/unhold
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 563c570263a827da3c538e42b0e1704136248b7e

@netlify
Copy link

netlify bot commented Aug 2, 2022

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit ccd2415
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62e92d60406168000849f008
😎 Deploy Preview https://deploy-preview-35359--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bart2001
Copy link
Contributor Author

bart2001 commented Aug 2, 2022

@yoonian
squash로 커밋 정리했습니다.

@seokho-son
base, target 브랜치 모두 dev-1.24-ko.2으로 변경하였습니다.

@seokho-son seokho-son removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 3, 2022
@seokho-son
Copy link
Member

감사합니다!!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit d50b53c into kubernetes:dev-1.24-ko.2 Aug 3, 2022
@jihoon-seo jihoon-seo mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoon-seo jihoon-seo jihoon-seo left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@yoonian yoonian Awaiting requested review from yoonian

Assignees

@yoonian yoonian

@jihoon-seo jihoon-seo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bart2001 @yoonian @k8s-ci-robot @seokho-son @jihoon-seo