Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ko] Translate the glossary term 'Ephemeral Container' into Korean #35279

Merged
merged 1 commit into from
Aug 4, 2022
Merged

[ko] Translate the glossary term 'Ephemeral Container' into Korean #35279

merged 1 commit into from
Aug 4, 2022

Conversation

jihoon-seo
Copy link
Member

Resolves #35258

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2022
@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jul 23, 2022
@netlify
Copy link

netlify bot commented Jul 23, 2022 •
edited
Loading

✅ Deploy Preview for k8s-dev-ko ready!

Name Link
🔨 Latest commit 3f21261
🔍 Latest deploy log https://app.netlify.com/sites/k8s-dev-ko/deploys/62e32f562f5ce700088793e2
😎 Deploy Preview https://deploy-preview-35279--k8s-dev-ko.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bart2001 bart2001 mentioned this pull request Jul 25, 2022
Merged
sftim
sftim reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's IMO useful to Korean readers to know that the term that the API uses is “ephemeral container” (actually ephemeralContainers, in the Pod API).

@sftim
Copy link
Contributor

sftim commented Jul 25, 2022

We could link to https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#EphemeralContainer even though the English doc doesn't mention this, provided that the justification for this link is helping readers understand what 임시 컨테이너 equates to in the API.

@seokho-son
Copy link
Member

It's IMO useful to Korean readers to know that the term that the API uses is “ephemeral container” (actually ephemeralContainers, in the Pod API).

Thank you @sftim :)
I have the same opinion with you. It will be useful to Korean readers.
So, the Korean l10n team has a convention in localizing the Glossary terms as well.
In case of glossary, we provides the original English term beside of the Korean title.

For instance,

https://raw.githubusercontent.com/kubernetes/website/main/content/ko/docs/reference/glossary/daemonset.md

title: 데몬셋(DaemonSet)
id: daemonset
date: 2018-04-12
full_link: /ko/docs/concepts/workloads/controllers/daemonset
short_description: >
  파드의 복제본을 클러스터 노드 집합에서 동작하게 한다.

@jihoon-seo could you apply the convention accordingly ?

@seokho-son
Copy link
Member

/assign

@jihoon-seo jihoon-seo force-pushed the 220723_ko_Add_glossary_term_Ephemeral-Container branch from 2aea467 to 3f21261 Compare July 29, 2022 00:52
@jihoon-seo
Copy link
Member Author

@sftim @seokho-son Thank you for your comments!
I reflected your suggestions. PTAL!

seokho-son
seokho-son reviewed Jul 29, 2022
View reviewed changes
content/ko/docs/reference/glossary/ephemeral-container.md
Comment on lines +19 to +20
<!-- Even though the English doc doesn't mention this, the link below is to help Korean readers understand what 임시 컨테이너 equates to in the API. -->
더 자세한 정보는 파드 API의 [EphemeralContainer](https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/pod-v1/#EphemeralContainer)를 참고한다.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoon-seo
해당 내용에 대해서 설명을 부탁드려도 될까요?
아시다시피 한글화의 경우 보통은 원문의 형태를 최대한 유지해왔었습니다. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

무슨 이유에서인지 이 댓글에 대한 노티 메일을 못 받았네요.. 🥲

@seokho-son
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a352b1e9407db53f958923719f65030e2b5cb99a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit b86d4eb into kubernetes:dev-1.24-ko.2 Aug 4, 2022
@jihoon-seo jihoon-seo deleted the 220723_ko_Add_glossary_term_Ephemeral-Container branch August 4, 2022 07:31
@jihoon-seo jihoon-seo mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@seokho-son seokho-son seokho-son left review comments

@claudiajkang claudiajkang Awaiting requested review from claudiajkang

@ianychoi ianychoi Awaiting requested review from ianychoi

Assignees

@seokho-son seokho-son

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jihoon-seo @sftim @seokho-son @k8s-ci-robot