Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moving intro-windows-in-kubernetes content out of /setup/production-environment/ #32768

Closed
wants to merge 1 commit into from
Closed

moving intro-windows-in-kubernetes content out of /setup/production-environment/ #32768

wants to merge 1 commit into from

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Apr 5, 2022

Signed-off-by: Mark Rossetti [email protected]

Part of #31428

/hold
We want to merge changes related to #31428 at the same time.

/sig windows
/label refactor

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Apr 5, 2022
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/windows Categorizes an issue or PR as relevant to SIG Windows. refactor Indicates a PR with large refactoring changes e.g. removes files or moves content cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 5, 2022
@netlify
Copy link

netlify bot commented Apr 5, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 12704e0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/624cc5e999b4e70008193dc2

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign tengqm after the PR has been reviewed.
You can assign the PR to them by writing /assign @tengqm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 5, 2022
@marosset marosset mentioned this pull request Apr 5, 2022
Open
31 tasks
@nate-double-u
Copy link
Contributor

Hi @marosset, I don't think this PR should target dev-1.24

@marosset
Copy link
Contributor Author

/close
I will squash the commits and create a single PR with all of the related changes targeting main.

@marosset marosset closed this Apr 27, 2022
@nate-double-u
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.24 milestone Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@tengqm tengqm Awaiting requested review from tengqm

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language refactor Indicates a PR with large refactoring changes e.g. removes files or moves content sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marosset @k8s-ci-robot @nate-double-u