Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Move Chinese language content from cn/ to zh/ #10504

Closed
wants to merge 1 commit into from
Closed

[WIP] Move Chinese language content from cn/ to zh/ #10504

wants to merge 1 commit into from

Conversation

zacharysarah
Copy link
Contributor

@zacharysarah zacharysarah commented Oct 4, 2018 •
edited
Loading

🛑 DO NOT MERGE 🛑
This PR is dependent on #10485 and #10503 merging first.
Once these PRs merge ☝️ this PR must be rebased on master.

This PR moves Chinese language content from cn/ to zh/ to conform with the ISO 639-1 naming scheme.

/assign @chenopis @tengqm

Change cn to zh
29930d9 
More work
@kubernetes-docs-i18n-bot kubernetes-docs-i18n-bot added the language/zh Issues or PRs related to Chinese language label Oct 4, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zacharysarah

If they are not already assigned, you can assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2018
@zacharysarah zacharysarah changed the title Move Chinese language content from cn/ to zh/ [WIP] Move Chinese language content from cn/ to zh/ Oct 4, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2018
zacharysarah
zacharysarah commented Oct 4, 2018
View reviewed changes
config.toml
title = "Kubernetes"
description = "Production-Grade Container Orchestration"
languageName = "Chinese"
# languageName = "Chinese"
languageName = "中文 Chinese"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tengqm Is this correct? Please correct me if there's a better idiom!

@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 29930d9

https://deploy-preview-10504--kubernetes-io-master-staging.netlify.com

1 similar comment
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 29930d9

https://deploy-preview-10504--kubernetes-io-master-staging.netlify.com

@zacharysarah
Copy link
Contributor Author

Closing in favor of #10485, which now includes this PR's commit as a cherry-pick. 🍒

@zacharysarah zacharysarah deleted the move-cn-to-zh branch October 6, 2018 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@stewart-yu stewart-yu Awaiting requested review from stewart-yu

Assignees

@tengqm tengqm

@chenopis chenopis

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/zh Issues or PRs related to Chinese language size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zacharysarah @k8s-ci-robot @k8sio-netlify-preview-bot @tengqm @chenopis @kubernetes-docs-i18n-bot