Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with k8s.io/docs/tasks/configure-pod-container/configure-service-account/ #7100

Closed
1 of 2 tasks
lchao111 opened this issue Jan 26, 2018 · 4 comments · Fixed by #7147
Closed
1 of 2 tasks

Issue with k8s.io/docs/tasks/configure-pod-container/configure-service-account/ #7100

lchao111 opened this issue Jan 26, 2018 · 4 comments · Fixed by #7147
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@lchao111
Copy link

lchao111 commented Jan 26, 2018 •
edited
Loading

This is a document error.

  • Feature Request
  • Bug Report

Problem:
Error from server: invalid character 'i' looking for beginning of object key string
from kubectl patch serviceaccount default -p '{"imagePullSecrets": [{"name": "myregistrykey"}]}'

Proposed Solution:
escape this JSON string by '\'
kubectl patch serviceaccount default -p '{\"imagePullSecrets\": [{\"name\": \"acrkey\"}]}'
Page to Update:
http://kubernetes.io/...
@zacharysarah zacharysarah added P2 good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 26, 2018
@anubhakushwaha
Copy link
Contributor

@lchao111 @zacharysarah I was willing to take this up

@zacharysarah
Copy link
Contributor

@anubhakushwaha Go for it! 👍

@anubhakushwaha anubhakushwaha mentioned this issue Jan 30, 2018
Merged
@anubhakushwaha
Copy link
Contributor

@zacharysarah Done

@eavonius
Copy link

This is still a problem here:

https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#add-image-pull-secret-to-service-account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated configure-service-account.md anubhakushwaha/website
4 participants
@eavonius @zacharysarah @lchao111 @anubhakushwaha