Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace handling in 'features-state' using Go comment tags #48331

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

r21gh
Copy link
Contributor

@r21gh r21gh commented Oct 14, 2024

Description

  • Utilized Go comment tags {{- /* Comment Text here */ -}} to manage whitespace
  • Improved indentation for better readability
  • Prevented unwanted line breaks or spaces in the rendered HTML output

Issue

Closes: #48323

/area web-development

- Utilized Go comment tags {{- /* Comment Text here */ -}} to manage whitespace
- Improved indentation for better readability
- Prevented unwanted line breaks or spaces in the rendered HTML output
@k8s-ci-robot k8s-ci-robot added area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign reylejano for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Oct 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 14, 2024
Copy link

netlify bot commented Oct 14, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c0e7831
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/670ccf3acfd424000838bd23
😎 Deploy Preview https://deploy-preview-48331--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tengqm
Copy link
Contributor

tengqm commented Oct 14, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5fbb9725aa80f3862bff5e626fb3cfd7adff1a3f

@sftim
Copy link
Contributor

sftim commented Oct 14, 2024

/assign @reylejano

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sftim
Copy link
Contributor

sftim commented Oct 15, 2024

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Display of HTML Code Tags in Declarative Config Task
6 participants