Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for k8s.io/docs/concepts/configuration/secret/ #48184

Open
Ostromix opened this issue Oct 3, 2024 · 8 comments
Open

Improvement for k8s.io/docs/concepts/configuration/secret/ #48184

Ostromix opened this issue Oct 3, 2024 · 8 comments
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Ostromix
Copy link

Ostromix commented Oct 3, 2024

Can you please add in documentation menu description about using such type of construction in
SECRET description in documentation

apiVersion: v1
kind: Pod
metadata:
labels:
name: supername
name: supername
namespace: supernamespace
spec:
containers:

  • image: superrepo/superimage
    name: supername
    envFrom:
    • secretRef:
      name: mysupersecret
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 3, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aryasoni98
Copy link

/assign

@utkarsh-singh1
Copy link
Contributor

Page link -> https://kubernetes.io/docs/concepts/configuration/secret/

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 4, 2024
@utkarsh-singh1
Copy link
Contributor

@Ostromix, there can be multiple ways to use secrets in PodSpec like using envFrom, valueFrom etc.

@utkarsh-singh1
Copy link
Contributor

So it will be better to point out the usage of such cases in the docs.

@network-charles
Copy link
Contributor

I believe this is what you are looking for.

https://kubernetes.io/docs/tasks/inject-data-application/distribute-credentials-secure/#configure-all-key-value-pairs-in-a-secret-as-container-environment-variables

This section describes an example that uses the “envFrom” field.

@utkarsh-singh1
Copy link
Contributor

This section describes an example that uses the “envFrom” field.

@Ostromix as above command describes there is already available, so I don't think there is need to change any docs, but we can mention this page in whats next section.

@network-charles
Copy link
Contributor

@utkarsh-singh1, the page is already referenced in this section.

@aryasoni98 aryasoni98 removed their assignment Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

5 participants