Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unclear] example: Deploying Cassandra with a StatefulSet #47039

Closed
brianjester opened this issue Jun 30, 2024 · 7 comments · Fixed by #47087 or #47277
Closed

[Unclear] example: Deploying Cassandra with a StatefulSet #47039

brianjester opened this issue Jun 30, 2024 · 7 comments · Fixed by #47087 or #47277
Assignees
Labels
language/en Issues or PRs related to English language sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@brianjester
Copy link

brianjester commented Jun 30, 2024

When running this command:

grace=$(kubectl get pod cassandra-0 -o=jsonpath='{.spec.terminationGracePeriodSeconds}') \
  && kubectl delete statefulset -l app=cassandra \
  && echo "Sleeping ${grace} seconds" 1>&2 \
  && sleep $grace \
  && kubectl delete persistentvolumeclaim -l app=cassandra

The grace period it was going to sleep was 1800s (30m), so after all resources were deleted (about 5-6s), I hit Ctrl-C, then manually ran the line after the sleep:

kubectl delete persistentvolumeclaim -l app=cassandra

Recommend adding a note to avoid having the student wait 30m for a command to finish that might only take a few seconds.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 30, 2024
@T-Lakshmi
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 30, 2024
@sftim
Copy link
Contributor

sftim commented Jun 30, 2024

I think we can improve the advice, or change the grace period to be quite a bit shorter. Not sure which is better.

@sftim
Copy link
Contributor

sftim commented Jun 30, 2024

/triage accepted
either way

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 30, 2024
@sftim
Copy link
Contributor

sftim commented Jul 2, 2024

/retitle [Unclear] example: Deploying Cassandra with a StatefulSet

@k8s-ci-robot k8s-ci-robot changed the title Example: Deploying Cassandra with a StatefulSet [Unclear] example: Deploying Cassandra with a StatefulSet Jul 2, 2024
@thisisharrsh
Copy link
Contributor

change the grace period to be quite a bit shorter

I have tried to reproduce the issue with a grace period of 300 seconds. And I observed that all my related resources were deleted in under 10 seconds.
It will be better if we reduce the terminationGracePeriodSeconds: 1800 to some shorter value like 300 or 500.

@thisisharrsh
Copy link
Contributor

I would like to work on this issue.

/assign
/sig apps
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jul 4, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jul 4, 2024
@abhilasha2418
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
6 participants