Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ready pod status still listed as a beta feature, became GA in 1.29 #44632

Open
hahewlet opened this issue Jan 4, 2024 · 11 comments
Open

ready pod status still listed as a beta feature, became GA in 1.29 #44632

hahewlet opened this issue Jan 4, 2024 · 11 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@hahewlet
Copy link

hahewlet commented Jan 4, 2024

This is a Bug Report

Problem:
According to KEP kubernetes/enhancements#2879, The JobReadyPods feature gate has moved to GA with K8s 1.29. I see this correctly reflected in the feature gate doc, https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/. However, the Job API doc, https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#JobStatus, lists the ready state as a beta feature. Text from the doc:

Beta level
ready (int32)

The number of pods which have a Ready condition.

This field is beta-level. The job controller populates the field when the feature gate JobReadyPods is enabled (enabled by default).

Proposed Solution:
Move the ready state information from the beta section to the main list under the JobStatus section.

Page to Update:
https://kubernetes.io/docs/reference/kubernetes-api/workload-resources/job-v1/#JobStatus

Kubernetes Version: 1.29

@hahewlet hahewlet added the kind/bug Categorizes issue or PR as related to a bug. label Jan 4, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 4, 2024
@hahewlet
Copy link
Author

hahewlet commented Jan 4, 2024

@alculquicondor for awareness.

@hahewlet hahewlet changed the title ready pods status still listed as a beta feature, became GA in 1.29 ready pod status still listed as a beta feature, became GA in 1.29 Jan 4, 2024
@alculquicondor
Copy link
Member

Uhm... this was already fixed kubernetes/kubernetes#121765

Not sure if there was a missing sync into the website page.

@hahewlet
Copy link
Author

hahewlet commented Jan 4, 2024

I don't see the markdown page explicitly listed in the committed files under kubernetes/kubernetes#121765. When I look in the main branch, https://github.com/kubernetes/website/blob/main/content/en/docs/reference/kubernetes-api/workload-resources/job-v1.md#beta-level-1 I see the beta reference. Perhaps this was missed?

@sftim
Copy link
Contributor

sftim commented Jan 4, 2024

/sig apps

If the API or command line tool reference is out of date, a contributor needs to regenerate it and then send in a pull request.

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Jan 4, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Jan 4, 2024
@sftim
Copy link
Contributor

sftim commented Jan 4, 2024

/language en
/triage accepted

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 4, 2024
@professorabhay
Copy link

Hey, @sftim ! I would like to do it.
Will raise a PR.

@Anuragt1104
Copy link

/assign

@professorabhay
Copy link

/unassign @Anuragt1104

@professorabhay
Copy link

Hey @Anuragt1104, I'm already working on it and will raise the PR soon.

@professorabhay
Copy link

/assign

@professorabhay
Copy link

Hey, @hahewlet ! Kindly take a look at the PR.

@kannon92 kannon92 moved this from Needs Triage to In Progress in SIG Apps Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: In Progress
6 participants