Remove duplicated wording reference to Docker Engine's legacy container links

[dancer1325]

This is a Bug Report
Remove duplicated wording reference to Docker Engine's legacy container links in the service page under the section environment variables

Problem:
Duplicated wording reference about the possibility to add variables compatible with Docker Engine's legacy container links feature

It also supports variables (see makeLinkVariables) that are compatible with Docker Engine's "legacy container links" feature.

And after Note commentary ...

Kubernetes also supports and provides variables that are compatible with Docker Engine's "legacy container links" feature. You can read makeLinkVariables to see how this is implemented in Kubernetes.

Proposed Solution:
Leave just 1

"Kubernetes also supports and provides variables that are compatible with Docker Engine's "legacy container links" feature. You can read makeLinkVariables to see how this is implemented in Kubernetes."

Page to Update:
https://kubernetes.io/docs/concepts/services-networking/service/

[dancer1325]

/language en

[rohan-kapse]

/assign

[sftim]

Whilst reviewing #44274, I concluded that this issue report isn't correctly reporting an actual bug. Kubernetes does support two kinds of environment variables that help you to discover Services.

/priority awaiting-more-evidence

[dancer1325]

Whilst reviewing #44274, I concluded that this issue report isn't correctly reporting an actual bug. Kubernetes does support two kinds of environment variables that help you to discover Services.

Then, @sftim ,

It also supports variables (see makeLinkVariables) that are compatible with Docker Engine's "legacy container links" feature.

and

Kubernetes also supports and provides variables that are compatible with Docker Engine's "legacy container links" feature. You can read makeLinkVariables to see how this is implemented in Kubernetes.

refer to different topics?

• Here just 1 commentary about it, and in 👁️ thisPR 👁️, although it's indicated that ## Environment variables section wasn't added,

Kubernetes also supports and provides variables that are compatible with Docker Engine's "legacy container links" feature. You can read makeLinkVariables to see how this is implemented in Kubernetes.

is added --> Isn't it redundant ?

[sftim]

Ah OK. So this is a genuine issue, but I think the proposed fix may be wrong.

/triage accepted
/remove-priority awaiting-more-evidence
/priority backlog
/kind bug

[dancer1325]

Thanks @sftim

I close this issue, since the PR was already merged! 🚀