Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stale "Twitter" icon and name (s) - should now be "X" corp. #43206

Open
aj11anuj opened this issue Sep 26, 2023 · 22 comments
Open

Stale "Twitter" icon and name (s) - should now be "X" corp. #43206

aj11anuj opened this issue Sep 26, 2023 · 22 comments
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@aj11anuj
Copy link
Member

This is a Feature Request

What would you like to be added/enhanced?
As everybody knows, Twitter is now under X corp. and its world famous blue bird icon has been changed to "X" icon a long time ago. So, maybe we should update it here in footer too.

Why is this needed?
I know everyone likes that blue twitter icon, and twitter is better recognised with that icon. But as company has been renamed to "X" with "X" icon then shouldn't we update it?
@aj11anuj aj11anuj added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 26, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 26, 2023
@aj11anuj
Copy link
Member Author

/area web-development

@k8s-ci-robot k8s-ci-robot added the area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes label Sep 26, 2023
@aj11anuj
Copy link
Member Author

/sig docs

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Sep 26, 2023
@sftim
Copy link
Contributor

sftim commented Sep 26, 2023

/kind bug
(the website is “wrong” now)

/priority backlog

Contributors: please feel free to work on other issues; this one isn't a priority.

/retitle Stale "Twitter" icon and name (s) - should now be "X" corp.

We use the Twitter logo and brand on https://kubernetes.io/community/ too

@k8s-ci-robot k8s-ci-robot changed the title Replacement of "Twitter" icon with "X" corp. icon at footer Stale "Twitter" icon and name (s) - should now be "X" corp. Sep 26, 2023
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 26, 2023
@Gauravpadam
Copy link
Member

/assign @Gauravpadam

@Gauravpadam
Copy link
Member

I'll look into this after other issues ; Meanwhile anyone can propose a fix

@aj11anuj
Copy link
Member Author

😅 I think it's priority backlog, but it's also reserved to be resolved in-future.

Currently, i guess no one is in favour to change it, but it will be updated in-future after several months.

@sftim
Copy link
Contributor

sftim commented Sep 26, 2023

/remove-kind feature

@k8s-ci-robot k8s-ci-robot removed the kind/feature Categorizes issue or PR as related to a new feature. label Sep 26, 2023
@pranshugupta01
Copy link

hi can i work on this issue?

@Gauravpadam
Copy link
Member

Sure @pranshugupta01, Go ahead

@tengqm
Copy link
Contributor

tengqm commented Oct 9, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 9, 2023
@pedoch
Copy link

pedoch commented Oct 17, 2023

Hi, it seems this issue is still open. Can I work on it for hacktoberfest?

@sftim
Copy link
Contributor

sftim commented Oct 17, 2023

Help is welcome. However, the Kubernetes project is not a participant in Hacktoberfest.

You can read https://hacktoberfest.com/participation/ to learn more.

@pedoch
Copy link

pedoch commented Oct 17, 2023

@sftim thank you, I realise that now.

I attempted working on the issue regardless. Looks like it'll required upgrading the fontawesome, but I honestly can't figure out how to do that. Fontawesome seems to be coming docusy?

Unfortunately, doesn't look I'd be of much help.

@chansuke
Copy link
Member

@Gauravpadam I'd like to work on this.

@Gauravpadam Gauravpadam mentioned this issue Nov 6, 2023
Closed
@Gauravpadam
Copy link
Member

@Gauravpadam I'd like to work on this.

Sure, Please go ahead

@rohan-kapse
Copy link
Contributor

@chansuke could u describe your approach plzz ?

@kundan2707 kundan2707 mentioned this issue Nov 9, 2023
Closed
@Gauravpadam Gauravpadam mentioned this issue Nov 18, 2023
Closed
@Manish-hr14
Copy link
Contributor

Manish-hr14 commented Dec 9, 2023 •
edited
Loading

/assign

This was referenced Dec 10, 2023
Merged
Merged
@Rajdeep1311
Copy link
Contributor

@Gauravpadam are you still working?

@Gauravpadam
Copy link
Member

@Rajdeep1311 Please go ahead and propose a fix

@Gauravpadam Gauravpadam removed their assignment Dec 13, 2023
@Manish-hr14
Copy link
Contributor

Manish-hr14 commented Dec 13, 2023 •
edited
Loading

@Rajdeep1311 issue has been solved already.

@Rajdeep1311
Copy link
Contributor

Rajdeep1311 commented Dec 13, 2023 •
edited
Loading

But I see PR was merged and again opened @Manish-hr14

@Gauravpadam
Copy link
Member

The footer still shows the "old" logo — shouldn't we update that too?

A docsy theme update might be necessary for this

@Okabe-Junya Okabe-Junya mentioned this issue Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests