Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Job completion-mode documentation has an unclarified note about a 'rare' condition #31719

Open
heyleke opened this issue Feb 11, 2022 · 10 comments
Labels
language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@heyleke
Copy link

heyleke commented Feb 11, 2022

This is a Bug Report

Problem:
https://kubernetes.io/docs/concepts/workloads/controllers/job/#completion-mode mentions

Note that, although rare, more than one Pod could be started for the same
index, but only one of them will count towards the completion count.

Can it be clarified why that note is needed? And if the pod is started, will it run to completion, or aborted before running or ... ?

Proposed Solution:
@alculquicondor proposes via kubernetes/enhancements#2214

We can clarify that it will be aborted.

Page to Update:
https://kubernetes.io/docs/concepts/workloads/controllers/job

@heyleke heyleke added the kind/bug Categorizes issue or PR as related to a bug. label Feb 11, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 11, 2022
@alculquicondor
Copy link
Member

alculquicondor commented Feb 11, 2022

As for why the note was added...
Due to the async nature of kubernetes, it's possible that we don't observe the creation of Pods in a timely manner. We have some in-memory guards in place to prevent double creation. So it's very unlikely that you would observe such behavior but we simply don't make guarantees.

Not sure how to express all of the above in a user-friendly way :) I'll wait for suggestions from tech-writers.

@sftim
Copy link
Contributor

sftim commented Feb 12, 2022

/sig apps
/language en

Help wanted, but this isn't necessarily easy enough to merit /help

/remove-kind bug
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 12, 2022
@sftim
Copy link
Contributor

sftim commented Feb 12, 2022

Thanks for the report @heyleke

@sftim
Copy link
Contributor

sftim commented Feb 12, 2022

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 12, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2022
@alculquicondor
Copy link
Member

I know of one instance kubernetes/kubernetes#109429. I think it's about the garbage collection, but I don't have enough evidence.

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 13, 2022
@wu0407
Copy link

wu0407 commented May 8, 2023

It occurrence many times in my cluster.
kubernetes/kubernetes#109429 (comment)

@mrgiles
Copy link
Contributor

mrgiles commented May 23, 2023

/assign

@mrgiles
Copy link
Contributor

mrgiles commented May 31, 2023

/unassign

@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Sep 29, 2023
@helayoty helayoty moved this from Needs Triage to Backlog in SIG Apps Sep 29, 2023
@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
Status: Backlog
Development

No branches or pull requests

7 participants