-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document API server /livez and /readyz #20888
Comments
/sig network node |
actually livez/readyz is kube-apiserver only, so: /remove-sig node network though, one way to get the attention of sig-api-machinery would have been to log this issue in k/kubernetes. |
/sig docs |
@johscheuer this sounds like reference documentation to me, rather than a task. |
That's right, @sftim do you have any preferred place where we could put this documentation? If so I would start writing down some documentation that can be reviewed by api-machinery. |
There's already https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/ (generated documentation). Maybe add https://kubernetes.io/docs/reference/using-api/health-checks/ (currently a 404)? |
If there's a place in the code for kube-apiserver to add text that ends up on https://kubernetes.io/docs/reference/command-line-tools-reference/kube-apiserver/ and explains the health checks, that's also a valid approach. |
I think https://kubernetes.io/docs/reference/using-api/health-checks/ is the best place, I don't think that the command line reference is the best place. I try to write something down this week. |
/language en |
This is a Feature Request
During creating this PR: kubernetes/kubernetes#90970 I found out that the
/livez
and/readyz
endpoints of the kube-apiserver are not really document. Also the documentation should highlight that/livez
and/readyz
are the new endpoints which should be used (otherwise some flags like--livez-grace-period
and--shutdown-delay-duration
will be ignored.What would you like to be added
It would be nice to describe the differences of the endpoints and when the specific endpoints should be used (or not). Probably a sub page in https://kubernetes.io/docs/tasks/administer-cluster would be nice (or maybe it fits somewhere else)
Why is this needed
It would be nice to know what endpoints should be used to create a
readinessProbe
and alivenessProbe
and what are the difference between these 3 endpoints.Comments
The text was updated successfully, but these errors were encountered: