Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left panel navigating bar layout and link bugs #18737

Closed
gaoguangze111 opened this issue Jan 17, 2020 · 9 comments · Fixed by #19517
Closed

Left panel navigating bar layout and link bugs #18737

gaoguangze111 opened this issue Jan 17, 2020 · 9 comments · Fixed by #19517
Assignees
Labels
language/zh Issues or PRs related to Chinese language

Comments

@gaoguangze111
Copy link
Contributor

This is a Bug Report

Problem:
The left panel navigating bar on Chinese version website has globally a extra sub option who has the same name with the main option. The first two sub options of a main option link to the same page.
bug

Proposed Solution:
Remove the first sub option

Page to Update:
https://kubernetes.io/...

@gaoguangze111
Copy link
Contributor Author

/language zh

@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jan 17, 2020
@tengqm
Copy link
Contributor

tengqm commented Jan 17, 2020

looks like a hugo thing to me, but I dont have bandwidth to investigate.

@gavinfish
Copy link
Contributor

/assign

@gavinfish
Copy link
Contributor

This may be a bug from hugo and I have submitted an issue gohugoio/hugo#6770. And I think it is ok for us to remove simple comments like below in _index.md files to mitigate this issue. What do you guys think?

<!--
---
title: "Kubernetes Architecture"
weight: 30
---
-->

@tanjunchen
Copy link
Member

I think this problem should be solved from the upstream first, I hope your issue can play a certain role. if it can't,we should reconsider this solution.what do you say?
about this series of problems, this pr #18694 , can work?

@gavinfish
Copy link
Contributor

@tanjunchen if hugo can fix this, I would love it to prevent lots of unnecessary work here. But I have no idea whether hugo team will provide a fix and when is the ETA.

And for that pr, its target is totally different. Remove the alias property is to prevent short link like kubernetes.io/security redirects to zh version instead of en one. Indeed, we can create a new issue to track the redirect issue with at least two follow ups:

  1. Whether it is necessary for different languages to have their own alias like kubernetes.io/zh/security?
  2. Make sure all the docs are at the same page for this issue.

@tanjunchen
Copy link
Member

@gavinfish yes . understand

@tanjunchen
Copy link
Member

any progress about this issue

@gavinfish
Copy link
Contributor

No updates from hugo. I will draft a PR to fix it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/zh Issues or PRs related to Chinese language
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants