Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review “Resource metrics” pipeline #17015

Closed
sftim opened this issue Oct 17, 2019 · 4 comments · Fixed by #17028
Closed

Review “Resource metrics” pipeline #17015

sftim opened this issue Oct 17, 2019 · 4 comments · Fixed by #17028
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@sftim
Copy link
Contributor

sftim commented Oct 17, 2019

Page to review
https://kubernetes.io/docs/tasks/debug-application-cluster/resource-metrics-pipeline/ mentions Kubernetes v1.8
Review this page, removing references to Kubernetes versions that are earlier than what's supported, and revising wording to suit.

Why is this needed
The documentation usually can and should assume that the reader is running a version of Kubernetes that is at least as new as the oldest version still supported.

Comments
/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 17, 2019
@miteshskj
Copy link
Contributor

@sftim - Is the intent to remove all references to versions (eg: feature foo was introduced in 1.x) or just where it's a requirement (eg: feature foo works with 1.+ or minimum version required is 1.x)? where 1.x is an unsupported version.

@aimeeu
Copy link
Contributor

aimeeu commented Oct 18, 2019

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 18, 2019
@sftim
Copy link
Contributor Author

sftim commented Oct 18, 2019

@miteshskj All references to unsupported versions. Anyone interested in history would, I think, be more likely to look at release notes or Git commit logs anyway.

Imagine that all pages start with “The following text assumes your cluster is running Kubernetes v1.12 or newer” (v1.12 because right now v1.12 is the oldest supported version), and that's why you can omit information about older versions.

However one possible exception, feature state. Ingress is in beta and has been since v1.1
The feature-state shortcode for Ingress correctly lists v1.1 as the version it went beta in. That'll be true forever, no matter how many later releases come out.
If / when Ingress goes GA then the feature-state on that page will update, of course.

@miteshskj
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
4 participants