Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s.io/docs/concepts/configuration/taint-and-toleration/ needs better contextual examples #16147

Closed
Benjamintf1 opened this issue Aug 29, 2019 · 6 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@Benjamintf1
Copy link
Contributor

Problem:
In the tolerations section it does not show the tolerations in context of where it fits into the podspec.
Proposed Solution:
show an entire podspec with the "tolerations" key at the same level of containers so users know where to place this data in their pod spec.
Page to Update:
https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/

@aimeeu
Copy link
Contributor

aimeeu commented Aug 30, 2019

Hi @Benjamintf1 (love the pic of the PWC puppy!) -
Would you be willing to put the changes in as a pull request? If you're not 100% confident about the technical accuracy of changes, mention it in the PR description, and possibly ask for tech review.
Thanks for your feedback!

@Benjamintf1
Copy link
Contributor Author

Should be fixed in #16157

@sftim
Copy link
Contributor

sftim commented Sep 18, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Sep 18, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 16, 2020
@Benjamintf1
Copy link
Contributor Author

Oh wow, this should have been closed a while ago. It's been merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants