Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/tasks/configure-pod-container/pull-image-private-registry/ #14615

Closed
agemooij opened this issue May 29, 2019 · 8 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@agemooij
Copy link
Contributor

Problem:
The "Pull an Image from a Private Registry" page does not mention the fact that image pull secrets can be specified through a service account. This has lead many of my colleagues to the conclusion that the only way to use custom image pull credentials is through direct modification of all pods being deployed.

Searching Google on image pull secrets only brings up this page but almost never brings up the page that contains the relevant documentation, e.g. the page on how to how to add image pull secrets to a service account.

Proposed Solution:
The "Pull an Image from a Private Registry" page should have an extra section at the bottom of this page that either copies or references the documentation on how to add image pull secrets to a service account. A simple reference to the possibility and a link to the relevant doc would already help a great deal.

Page to Update:
https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/

Kubernetes Version:
All current versions

@sftim
Copy link
Contributor

sftim commented May 29, 2019

@agemooij - thanks for this suggestion. Sounds like a good idea!

@sftim
Copy link
Contributor

sftim commented May 31, 2019

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label May 31, 2019
@sftim
Copy link
Contributor

sftim commented May 31, 2019

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 31, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 29, 2019
@agemooij
Copy link
Contributor Author

agemooij commented Sep 2, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 2, 2019
@sftim
Copy link
Contributor

sftim commented Oct 14, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Oct 14, 2019
@sftim
Copy link
Contributor

sftim commented Oct 14, 2019

Did PR #14669 cover this by providing a helpful link?

@agemooij
Copy link
Contributor Author

@sftim yes, that's great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants