Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReplicaSet concept topic #12081

Closed
1 task
steveperry-53 opened this issue Jan 4, 2019 · 9 comments
Closed
1 task

Update ReplicaSet concept topic #12081

steveperry-53 opened this issue Jan 4, 2019 · 9 comments

Comments

@steveperry-53
Copy link
Contributor

This is a...

  • [ x] Feature Request
  • Bug Report

Proposed Solution:
Update the ReplicaSets concept topic.

  • Remove time-sensitive phrases like "is the next-generation".
  • Bring text and code examples into alignment with our style guide.
  • Add an explanation of how a Pod has an ownerReference, and a ReplicaSet can be the owner of a
    Pod.
  • Explain in detail how the ReplicaSet controller bases its actions on both Pod labels and Pod
    ownerReference.
  • Possibly simplify code examples. For example, why does the main example have both matchLabels
    and matchExpressions?
selector:
    matchLabels:
      tier: frontend
    matchExpressions:
      - {key: tier, operator: In, values: [frontend]}

Page to Update:
https://kubernetes.io/docs/concepts/workloads/controllers/replicaset/#pod-selector

@steveperry-53
Copy link
Contributor Author

Contacts: @chenopis, @steveperry-53

@zacharysarah
Copy link
Contributor

/cc @juandiegopalominocardich

@juandiegopalomino
Copy link
Contributor

👍

@bradtopol bradtopol self-assigned this Feb 12, 2019
@bradtopol
Copy link
Contributor

@steveperry-53 @zacharysarah I assigned myself this topic and should be able to start it next week. I'm at a conference this week. If someone can work on it sooner let me know and I will unassign myself.

@zacharysarah
Copy link
Contributor

@bradtopol Thanks, I think @juandiegopalomino has a PR well in progress already.

JD, would you please edit your PR’s original description to include the following on a single line:
fixes #12081
Thanks!

@juandiegopalomino
Copy link
Contributor

@zacharysarah done, and my pr is already merged

@DanyC97
Copy link
Contributor

DanyC97 commented Feb 26, 2019

so i guess this issue is fixed hence can be closed now that 12409 is merged ?

@juandiegopalomino
Copy link
Contributor

I guess so?

@DanyC97
Copy link
Contributor

DanyC97 commented Feb 27, 2019

@steveperry-53 you agree? if so you mind closing the issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants