Remove automatic --repo flag from bazel runner. #2416
Conversation
If a periodic job uses the bazelbuild image and passes an argument of "--repo=...", it ends up getting appended to the list of repos instead of overwriting it. Since not all jobs want this behavior, move the --repo flag to config.yaml per job instead. This also reverts the attempted (failed) workaround from kubernetes#2393.
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @spxtr |
|
How confident are you that this won't break anything? |
|
Not as confident as I was in #2415 which would have preserved backwards-compatibility :-). How about I trim the PR down to just creating the new image and updating a few jobs to use it, and I can monitor and wait for them to pass, and slowly create additional PRs to roll out the update to the rest of the jobs? Is there a better way to ensure this is safe? |
|
you can try to run the pod locally, https://github.com/kubernetes/test-infra/blob/master/experiment/pod.yaml might be a good reference |
| args: | ||
| - "--repo=k8s.io/$(REPO_NAME)" |
There was a problem hiding this comment.
Rather than saying $(REPO_NAME), why not just say kubernetes?
There was a problem hiding this comment.
The original intent was to make the job definitions even easier to copy/paste (say, between kubernetes and kubernetes-security) without having to tweak, but if you think it sacrifices readability, I'm pretty ambivalent.
|
BTW I'm working on a better way to test this kind of change. Do you mind waiting another day or two for that to come out and then we can use this PR as a test? |
|
@spxtr Completely fine. Sounds like a great improvement! |
|
I believe this has been superseded by ixdy's recent changes. Closing. |
If a periodic job uses the bazelbuild image and passes an argument of
--repo=..., it ends up getting appended to the list of repos instead of overwriting it. Since not all jobs want this behavior, move the--repoflag toconfig.yamlper job instead.This also reverts the attempted (failed) workaround from #2393.
(See also previous effort: #2415)