Allow disabling automatic --repo flag in bazel runner. #2415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a periodic job uses the bazelbuild image and passes an argument of "--repo=...", it ends up getting appended to the list of repos instead of overwriting it. This change lets jobs set an environment variable to opt out of this automatic --repo flag added by the bazel runner. This also reverts the attempted (failed) workaround from kubernetes#2393.
k8s-ci-robot
added
the
cncf-cla: yes
|
I'm not a fan of yet another magic environment variable. Why not just set |
|
Sounds good to me, I just generally try to avoid breaking backwards-compatibility. I'll take another swing at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a periodic job uses the bazelbuild image and passes an argument of
--repo=..., it ends up getting appended to the list of repos instead of overwriting it. This change lets jobs set an environment variable to opt out of this automatic--repoflag added by the bazel runner (naming suggestions welcome).I also considered and prototyped forking the bazelbuild image into another "periodic" variant to fix the issue, but since the delta turned out to be a single line deleted in the runner, the long-term cost of maintaining two forks of the image seemed to heavily outweigh the alternative of this new environment variable. I'm still open to suggestions, though.
This also reverts the attempted (failed) workaround from #2393.