Fix periodic bazel jobs. #2393
Merged
Fix periodic bazel jobs. #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bazel runner already specifies a --repo argument based off of $REPO_NAME, so adding a second --repo option was checking out the kubernetes repo, but making the test-infra repo primary, so it failed the job because there was no "bazel-build" target in test-infra.
k8s-ci-robot
added
the
cncf-cla: yes
13 tasks
pipejakob
added a commit
to pipejakob/test-infra
that referenced
this pull request
Apr 5, 2017
If a periodic job uses the bazelbuild image and passes an argument of "--repo=...", it ends up getting appended to the list of repos instead of overwriting it. This change is to make the runner detect if it's being run in a periodic context, and if so, not add its own --repo flag. This also reverts the attempted (failed) workaround from kubernetes#2393.
pipejakob
added a commit
to pipejakob/test-infra
that referenced
this pull request
Apr 5, 2017
If a periodic job uses the bazelbuild image and passes an argument of "--repo=...", it ends up getting appended to the list of repos instead of overwriting it. This change lets jobs set an environment variable to opt out of this automatic --repo flag added by the bazel runner. This also reverts the attempted (failed) workaround from kubernetes#2393.
pipejakob
added a commit
to pipejakob/test-infra
that referenced
this pull request
Apr 5, 2017
If a periodic job uses the bazelbuild image and passes an argument of "--repo=...", it ends up getting appended to the list of repos instead of overwriting it. Since not all jobs want this behavior, move the --repo flag to config.yaml per job instead. This also reverts the attempted (failed) workaround from kubernetes#2393.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bazel runner already specifies a
--repoargument based off of$REPO_NAME, so adding a second--repooption was checking out the kubernetes repo, but making the test-infra repo primary, so it failed the job because there was nobazel-buildtarget in test-infra.I'm looking for feedback to see whether this approach is better than forking the bazelbuild image to create a runner more suitable for periodic jobs.
CC @spxtr @mikedanese