Only up/down kubeadm clusters for testing. #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/assign @krzyzacy Should this migrate to a scenario? |
pipejakob
force-pushed
the
kubeadm-e2e-only-updown
branch
from
8149223 to
448ec4d
Compare
13 tasks
|
sorry did not see this one. yeah I have #2141 standby, I'll let @pipejakob to make the kubeadm job pass first. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TODO from source.
For more context, this job has been red for a while because it was never blocking and there have been a lot of breaking upstream kubeadm changes leading to the beta. Now that things are settling down, I'm trying to get the job back into a green state and hopefully make a PR-blocking version to keep it green. I still want to get
--testworking as well, but a reliable job that will prevent regressions is incrementally better than what we have now.